eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk, ogl] Add VK_QCOM ZTC, Bspline, Mitchell filter weights, add MMPX filter #2577

Merged
CamilleLaVey merged 5 commits from liz-qcom-weights into master 2025-10-07 06:35:59 +02:00
Conversation 13 Commits 5 Files changed 21 +395 -60
Lizzie commented 2025-09-25 09:46:22 +02:00
Member
Copy link

Adds native support for QCOM cubic filter weights, and for devices whom do not support said weights, just implement them in shaders

TODO: ZTC filter is wrong!?

Signed-off-by: lizzie lizzie@eden-emu.dev

Adds native support for QCOM cubic filter weights, and for devices whom do not support said weights, just implement them in shaders TODO: ZTC filter is wrong!? Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-25 09:46:23 +02:00
[vk, ogl] VK_QCOM ZTC, Bspline, Mitchell filter weights
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
9feb16208f 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 2 commits 2025-09-25 09:57:10 +02:00 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix vk
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
6ab6ed8fe3 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-25 10:04:17 +02:00
better logic
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Details
4e36e9d6ed 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-25 19:25:57 +02:00
add MMPX filter
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
9828a387a9 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from WIP: [vk, ogl] VK_QCOM ZTC, Bspline, Mitchell filter weights to [vk, ogl] Add VK_QCOM ZTC, Bspline, Mitchell filter weights, add MMPX filter 2025-09-25 19:29:29 +02:00
requested reviews from MaranBr, crueter, CamilleLaVey, Maufeat, MrPurple666 2025-09-25 19:29:29 +02:00
Lizzie force-pushed liz-qcom-weights from 9828a387a9 to d16d86ee08 2025-09-25 19:29:38 +02:00 Compare
Lizzie force-pushed liz-qcom-weights from d16d86ee08 to 87920737eb 2025-09-26 04:05:07 +02:00 Compare
MaranBr approved these changes 2025-09-26 04:43:22 +02:00
Dismissed
crueter requested changes 2025-09-26 05:15:27 +02:00
Dismissed
docs/User.md Outdated
@ -12,0 +26,4 @@
- **ScaleForce**: Experimental texture upscale method, see [ScaleFish](https://github.com/BreadFish64/ScaleFish).
- **FSR**: Uses AMD FidelityFX Super Resolution to enhance image quality.
- **Area**: Area interpolation (high kernel count).
- **MMPX**: Nearest-neighbour filter aimed at providing higher pixel-art quality.
crueter commented 2025-09-26 05:15:26 +02:00
Owner
Copy link

let's make separate user-facing docs and dev docs i.e. as a user directory

let's make separate user-facing docs and dev docs i.e. as a user directory
Lizzie commented 2025-09-26 05:17:10 +02:00
Author
Member
Copy link

The language in the filters is pretty simple for users. Right now we don't have a lot of user documentation but if we add more we should do that in another separate PR.

The language in the filters is pretty simple for users. Right now we don't have a lot of user documentation but if we add more we should do that in another separate PR.
crueter marked this conversation as resolved
crueter reviewed 2025-09-26 05:18:50 +02:00
src/video_core/renderer_opengl/gl_blit_screen.cpp Outdated
@ -103,1 +113,4 @@
break;
case Settings::ScalingFilter::Mmpx:
window_adapt = MakeMmpx(device);
break;
crueter commented 2025-09-26 05:18:50 +02:00
Owner
Copy link

I'm incredibly attempted to macro this

I'm incredibly attempted to macro this
crueter approved these changes 2025-09-26 05:19:12 +02:00
Dismissed
Shinmegumi force-pushed liz-qcom-weights from 87920737eb to e6face74c6 2025-09-26 17:31:02 +02:00 Compare
Shinmegumi dismissed MaranBr's review 2025-09-26 17:31:02 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Shinmegumi dismissed crueter's review 2025-09-26 17:31:02 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Shinmegumi commented 2025-09-26 17:34:23 +02:00
Owner
Copy link

@Lizzie, is the filter done? Is there anything left to do or can this be merged?

@Lizzie, is the filter done? Is there anything left to do or can this be merged?
Lizzie commented 2025-09-26 20:05:39 +02:00
Author
Member
Copy link

@Shinmegumi wrote in #2577 (comment):

@Lizzie, is the filter done? Is there anything left to do or can this be merged?

This can be safely tested and merged now. I'd want VK_QCOM-capable devices to test that "native bicubic weight filtering" is working atleast.

@Shinmegumi wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2577#issuecomment-4814: > @Lizzie, is the filter done? Is there anything left to do or can this be merged? This can be safely tested and merged now. I'd want VK_QCOM-capable devices to test that "native bicubic weight filtering" is working atleast.
Lizzie force-pushed liz-qcom-weights from e6face74c6 to 97d2b08713 2025-09-27 00:10:31 +02:00 Compare
Lizzie force-pushed liz-qcom-weights from 97d2b08713 to ac88d14331 2025-09-27 01:05:55 +02:00 Compare
crueter commented 2025-09-27 01:39:17 +02:00
Owner
Copy link
     org.yuzu.yuzu_emu.app-mergeGenshinSpoofReleaseResources-62:/values/values.xml:310: error: resource string/scaling_filter_spline1 (aka com.miHoYo.Yuanshen:string/scaling_filter_spline1) not found.
     org.yuzu.yuzu_emu.app-mergeGenshinSpoofReleaseResources-62:/values/values.xml:312: error: resource string/scaling_filter_lanczos (aka com.miHoYo.Yuanshen:string/scaling_filter_lanczos) not found.
``` org.yuzu.yuzu_emu.app-mergeGenshinSpoofReleaseResources-62:/values/values.xml:310: error: resource string/scaling_filter_spline1 (aka com.miHoYo.Yuanshen:string/scaling_filter_spline1) not found. org.yuzu.yuzu_emu.app-mergeGenshinSpoofReleaseResources-62:/values/values.xml:312: error: resource string/scaling_filter_lanczos (aka com.miHoYo.Yuanshen:string/scaling_filter_lanczos) not found. ```
Lizzie force-pushed liz-qcom-weights from ac88d14331 to d6f5f3d36b 2025-09-27 01:42:45 +02:00 Compare
Lizzie force-pushed liz-qcom-weights from d6f5f3d36b to 74170da769 2025-09-27 15:02:08 +02:00 Compare
MaranBr force-pushed liz-qcom-weights from 74170da769 to f484944d2d 2025-09-28 07:58:04 +02:00 Compare
MaranBr approved these changes 2025-09-28 16:31:53 +02:00
Dismissed
Lizzie force-pushed liz-qcom-weights from f484944d2d to 36fae75437 2025-09-29 19:57:07 +02:00 Compare
Lizzie dismissed MaranBr's review 2025-09-29 19:57:07 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr force-pushed liz-qcom-weights from 36fae75437 to 4e9ede3e85 2025-09-30 02:55:18 +02:00 Compare
MaranBr approved these changes 2025-09-30 02:55:25 +02:00
Dismissed
Lizzie force-pushed liz-qcom-weights from 4e9ede3e85 to 251fc7435a 2025-10-02 23:23:40 +02:00 Compare
Lizzie force-pushed liz-qcom-weights from 251fc7435a to cce9740b79 2025-10-04 09:35:27 +02:00 Compare
CamilleLaVey approved these changes 2025-10-07 05:29:25 +02:00
Dismissed
MaranBr approved these changes 2025-10-07 06:31:16 +02:00
Dismissed
Lizzie force-pushed liz-qcom-weights from cce9740b79 to ce78c218f4 2025-10-07 06:32:46 +02:00 Compare
Lizzie dismissed CamilleLaVey's review 2025-10-07 06:32:47 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed MaranBr's review 2025-10-07 06:32:47 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr approved these changes 2025-10-07 06:35:02 +02:00
CamilleLaVey approved these changes 2025-10-07 06:35:48 +02:00
CamilleLaVey merged commit dbeae7add0 into master 2025-10-07 06:35:59 +02:00
CamilleLaVey deleted branch liz-qcom-weights 2025-10-07 06:36:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
MrPurple666
MaranBr
CamilleLaVey
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2577
No description provided.
Delete branch "liz-qcom-weights"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?