eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[common] replace Common::BitSet with std::bitset #2576

Merged
crueter merged 3 commits from lizbitsetst into master 2025-09-27 01:21:15 +02:00
Conversation 2 Commits 3 Files changed 3 +18 -98
Lizzie commented 2025-09-25 07:21:29 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-25 07:21:30 +02:00
[common] replace Common::BitSet with std::bitset
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
49dd374843 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
requested reviews from MrPurple666, MaranBr, CamilleLaVey, Maufeat, crueter 2025-09-25 07:21:30 +02:00
Lizzie added 1 commit 2025-09-25 07:34:51 +02:00
thanks clang
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
a86b2cb776 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-09-25 09:08:14 +02:00
cmake
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
cbed87d75b 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter approved these changes 2025-09-26 05:00:22 +02:00
crueter left a comment
Owner
Copy link

doesn't mcl have something like this too or am I misremembering?

doesn't mcl have something like this too or am I misremembering?
Lizzie commented 2025-09-26 05:03:41 +02:00
Author
Member
Copy link

@crueter wrote in #2576 (comment):

doesn't mcl have something like this too or am I misremembering?

we don't want to use mcl, and no it's not present there (only bit ops) - in fact other parts of the code use std::bitset!

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2576#issuecomment-4762: > doesn't mcl have something like this too or am I misremembering? we don't want to use mcl, and no it's not present there (only bit ops) - in fact other parts of the code use std::bitset!
crueter merged commit 020ad29a8c into master 2025-09-27 01:21:15 +02:00
crueter deleted branch lizbitsetst 2025-09-27 01:21:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2576
No description provided.
Delete branch "lizbitsetst"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?