eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[Vulkan] Descriptor Pool bug fix #2564

Merged
crueter merged 1 commit from Descriptor_pool_bug into master 2025-09-26 04:58:10 +02:00
Conversation 5 Commits 1 Files changed 1 +1 -1
wildcard commented 2025-09-24 10:26:49 +02:00
Member
Copy link

a bank could be (incorrectly) considered a superset if it had enough image buffer descriptors but not enough storage image descriptors, causing the allocator to pick a bank that can’t actually satisfy VK_DESCRIPTOR_TYPE_STORAGE_IMAGE demand resulting in sham allocations and creation of new pools.
Note to testers,
please look for any regressions in terms of visuals and most importantly please test the performance and ram usage.

a bank could be (incorrectly) considered a superset if it had enough image buffer descriptors but not enough storage image descriptors, causing the allocator to pick a bank that can’t actually satisfy VK_DESCRIPTOR_TYPE_STORAGE_IMAGE demand resulting in sham allocations and creation of new pools. Note to testers, please look for any regressions in terms of visuals and most importantly please test the performance and ram usage.
wildcard added 1 commit 2025-09-24 10:26:50 +02:00
[Vulkan] Descriptor Pool bug fix
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
244b121cee 
a bank could be (incorrectly) considered a superset if it had enough image buffer descriptors but not enough storage image descriptors, causing the allocator to pick a bank that can’t actually satisfy VK_DESCRIPTOR_TYPE_STORAGE_IMAGE demand resulting in sham allocations and creation of new pools.
Note to testers,
please look for any regressions in terms of visuals and most importantly please test the performance and ram usage.
requested reviews from MaranBr, Lizzie, CamilleLaVey, Maufeat, crueter, MrPurple666 2025-09-24 10:26:50 +02:00
wildcard added 1 commit 2025-09-24 10:27:51 +02:00
Fix License headers
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
f022b303d8
MaranBr force-pushed Descriptor_pool_bug from f022b303d8 to 7f0f1e20b7 2025-09-24 22:16:28 +02:00 Compare
MaranBr approved these changes 2025-09-24 22:16:34 +02:00
Shinmegumi approved these changes 2025-09-25 15:04:13 +02:00
Shinmegumi commented 2025-09-25 15:06:06 +02:00
Owner
Copy link

Approved, but waiting on feedback from Android and Linux before merging.

Approved, but waiting on feedback from Android and Linux before merging.
MaranBr force-pushed Descriptor_pool_bug from 7f0f1e20b7 to f5b3c7c6b6 2025-09-26 04:50:37 +02:00 Compare
Lizzie approved these changes 2025-09-26 04:53:57 +02:00
crueter approved these changes 2025-09-26 04:58:06 +02:00
crueter merged commit 10aca2f90c into master 2025-09-26 04:58:10 +02:00
crueter deleted branch Descriptor_pool_bug 2025-09-26 04:58:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
MaranBr
Shinmegumi
Lizzie
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2564
No description provided.
Delete branch "Descriptor_pool_bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?