eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[texture_cache] fix msaa upload again, #2550

Merged
CamilleLaVey merged 3 commits from fix_msaa_again into master 2025-09-23 03:49:37 +02:00
Conversation 3 Commits 3 Files changed 1 +19 -24
Maufeat commented 2025-09-22 18:14:18 +02:00
Member
Copy link

temproary non-msaa images used for msaa uploads were being destroyed before the GPU finished using them, causing validation errors/crashes.
This keeps the temp image alive until the GPU finishes and switches the aspect-mask check to bitwise so the MSAA path only runs when needed.

temproary non-msaa images used for msaa uploads were being destroyed before the GPU finished using them, causing validation errors/crashes. This keeps the temp image alive until the GPU finishes and switches the aspect-mask check to bitwise so the MSAA path only runs when needed.
Maufeat added 3 commits 2025-09-22 18:14:18 +02:00
remove previous changes already merged
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
8646427070
requested reviews from CamilleLaVey, crueter, MrPurple666, MaranBr, Lizzie 2025-09-22 18:14:18 +02:00
Maufeat force-pushed fix_msaa_again from 8646427070 to 40b0b0cfc8 2025-09-22 18:40:31 +02:00 Compare
MaranBr approved these changes 2025-09-22 19:30:42 +02:00
CamilleLaVey approved these changes 2025-09-23 03:16:42 +02:00
Lizzie approved these changes 2025-09-23 03:42:38 +02:00
CamilleLaVey merged commit aec7f19b7e into master 2025-09-23 03:49:37 +02:00
CamilleLaVey deleted branch fix_msaa_again 2025-09-23 03:49:38 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
crueter
MrPurple666
MaranBr
CamilleLaVey
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2550
No description provided.
Delete branch "fix_msaa_again"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?