[core, android] Initial playtime implementation #2535

inix · 2025-09-20T08:10:16+02:00

inix commented

2025-09-20 08:10:16 +02:00

So firstly, playtime code is moved to src/common and qt specific code to yuzu/utils.cpp.

The dependency on ProfileManager was removed because it was working properly on Android, and I think a shared playtime is better behavior.
Now, playtime is stored in a file called "playtime.bin".

JNI code is from Azahar although modified by me, as well as that I added code to reset the game's playtime which was missing for some reason on there.

Before this gets merged, I plan to add the ability to manually edit the database as well.

Note: Code still needs a bit of cleanup.

So firstly, playtime code is moved to src/common and qt specific code to yuzu/utils.cpp. The dependency on ProfileManager was removed because it was working properly on Android, and I think a shared playtime is better behavior. Now, playtime is stored in a file called "playtime.bin". JNI code is from Azahar although modified by me, as well as that I added code to reset the game's playtime which was missing for some reason on there. Before this gets merged, I plan to add the ability to manually edit the database as well. Note: Code still needs a bit of cleanup.

inix added 1 commit 2025-09-20 08:10:16 +02:00

WIP: [core, android] Initial playtime implementation

eden-license / license-header (pull_request) Failing after 17s

Details

d71814a68b

JNI code is from Azahar although modified

inix commented

2025-09-20 08:11:18 +02:00

I am aware of the frontend_common rework, files can be moved once that's merged.

crueter commented

2025-09-20 15:11:56 +02:00

I would argue the playtime manager should be moved into frontend_common. A similar thing was done with the firmware manager

crueter commented

2025-09-20 15:34:53 +02:00

Also--qt_common is already merged so you can probably move that stuff to qt_common/qt_playtime_manager.*

Also--qt_common is already merged so you can probably move that stuff to `qt_common/qt_playtime_manager.*`

inix force-pushed playtime-android from d71814a68b to 4c7c2957ac

2025-10-09 18:38:54 +02:00

Compare

inix added 1 commit 2025-10-09 18:40:26 +02:00

license fix

eden-license / license-header (pull_request) Failing after 25s

Details

a4ac75d963

inix changed title from ~~WIP: [core, android] Initial playtime implementation~~ to [core, android] Initial playtime implementation

2025-10-09 18:40:50 +02:00

requested reviews from MaranBr, Lizzie, crueter, CamilleLaVey, Maufeat, MrPurple666

2025-10-09 18:40:51 +02:00

inix added 1 commit 2025-10-09 18:42:50 +02:00

frontend common license fix

eden-license / license-header (pull_request) Successful in 24s

Details

8c75831911

inix commented

2025-10-09 18:45:04 +02:00

Also--qt_common is already merged so you can probably move that stuff to qt_common/qt_playtime_manager.*

I moved the qt specific code there

> Also--qt_common is already merged so you can probably move that stuff to `qt_common/qt_playtime_manager.*` I moved the qt specific code there

crueter requested changes 2025-10-09 18:49:08 +02:00

src/qt_common/qt_playtime_manager.cpp

					
				@ -0,0 +37,4 @@

				    default:

				        return QStringLiteral("0");

				    }

				}

crueter commented

2025-10-09 18:48:19 +02:00

In these cases I would recommend making them FrontendCommon methods that return std::strings. For the ReadablePlayTime you can use fmt::format like in my DataManager PR

crueter marked this conversation as resolved

src/yuzu/game_list.cpp

					
				@ -565,2 +564,4 @@

				    QAction* remove_shader_cache = remove_menu->addAction(tr("Remove All Pipeline Caches"));

				    QAction* remove_all_content = remove_menu->addAction(tr("Remove All Installed Contents"));

				    QMenu* play_time_menu = context_menu.addMenu(tr("Manage Play Time"));

				    QAction* set_play_time = play_time_menu->addAction(tr("Set Play Time Data"));

crueter commented

2025-10-09 18:48:41 +02:00

"Edit" would work better here

crueter marked this conversation as resolved

src/yuzu/main.cpp

					
				@ -2637,0 +2639,4 @@

				void GMainWindow::OnGameListSetPlayTime(u64 program_id) {

				    QDialog dialog(this);

				    dialog.setWindowTitle(tr("Set Play Time Data"));

				    dialog.setModal(true);

crueter commented

2025-10-09 18:43:55 +02:00

We can probably make this a .ui file

crueter marked this conversation as resolved

src/yuzu/main.cpp

					
				@ -2637,0 +2645,4 @@

				    auto* input_layout = new QHBoxLayout();

				    auto* hours_edit = new QLineEdit(&dialog);

				    auto* minutes_edit = new QLineEdit(&dialog);

				    auto* seconds_edit = new QLineEdit(&dialog);

crueter commented

2025-10-09 18:43:47 +02:00

These can be spin boxes

crueter marked this conversation as resolved

src/yuzu/main.cpp

					
				@ -2637,0 +2649,4 @@

				    hours_edit->setValidator(new QIntValidator(0, 9999, hours_edit));

				    minutes_edit->setValidator(new QIntValidator(0, 59, minutes_edit));

				    seconds_edit->setValidator(new QIntValidator(0, 59, seconds_edit));

crueter commented

2025-10-09 18:45:05 +02:00

And if we do go with QSpinBox you can just set the range and this won't be necessary

crueter marked this conversation as resolved

src/yuzu/main.cpp Outdated

					
				@ -2637,0 +2651,4 @@

				    minutes_edit->setValidator(new QIntValidator(0, 59, minutes_edit));

				    seconds_edit->setValidator(new QIntValidator(0, 59, seconds_edit));

				    using QtCommon::PlayTimeManager::TimeUnit;

crueter commented

2025-10-09 18:45:33 +02:00

You can remove the TimeUnit and then QtCommon::PlayTimeManager::GetPlayTimeUnit can also be shortened

You can remove the TimeUnit and then `QtCommon::PlayTimeManager::GetPlayTimeUnit` can also be shortened

crueter marked this conversation as resolved

src/yuzu/main.cpp

					
				@ -2637,0 +2681,4 @@

				    connect(button_box, &QDialogButtonBox::accepted, [&]() {

				        const int hours = hours_edit->text().toInt();

				        const int minutes = minutes_edit->text().toInt();

				        const int seconds = seconds_edit->text().toInt();