eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[gpu/nvdrv] Unstub SetErrorNotifier, add PostErrorNotification function #2500

Open
SDK-Chan wants to merge 2 commits from unstub-ErrorNotification into master
pull from: unstub-ErrorNotification
merge into: eden-emu:master
Conversation 3 Commits 2 Files changed 2 +126 -5
SDK-Chan commented 2025-09-17 15:19:17 +02:00
Member
Copy link

This commit should ensure that GPU error handling is handled correctly.
Replace some unimplemented stubs with PostErrorNotification.
I believe this should mitigate some hiccups encountered in unreal engine based games.

This commit should ensure that GPU error handling is handled correctly. Replace some unimplemented stubs with PostErrorNotification. I believe this should mitigate some hiccups encountered in unreal engine based games.
SDK-Chan added 2 commits 2025-09-17 15:19:18 +02:00
[gpu/nvdrv] Remove redundant whitespace
All checks were successful
eden-license / license-header (pull_request) Successful in 39s
Details
2a233cdaef
Shinmegumi approved these changes 2025-09-17 17:59:55 +02:00
Shinmegumi force-pushed unstub-ErrorNotification from 2a233cdaef to b0e8e27212 2025-09-17 21:41:11 +02:00 Compare
MaranBr force-pushed unstub-ErrorNotification from b0e8e27212 to 8546613823 2025-09-18 04:03:41 +02:00 Compare
MaranBr commented 2025-09-18 16:06:29 +02:00
Member
Copy link

There are some bugs reported by PistolaoBR in practically every game he tested.

There are some bugs reported by PistolaoBR in practically every game he tested.
Shinmegumi commented 2025-09-18 16:16:12 +02:00
Owner
Copy link

I'm wondering if the slow downs are due to new logging or this service getting bashed hard. I believe most of the bugs were slowdowns and things that were already present in other PRs, but I'd have to look at ones prior to confirm.

I am rebasing this. Let's test it with #2501 merged to master and see if that makes any change.

I'm wondering if the slow downs are due to new logging or this service getting bashed hard. I believe most of the bugs were slowdowns and things that were already present in other PRs, but I'd have to look at ones prior to confirm. I am rebasing this. Let's test it with #2501 merged to master and see if that makes any change.
Shinmegumi force-pushed unstub-ErrorNotification from 8546613823 to e81a358d83 2025-09-18 16:16:17 +02:00 Compare
Shinmegumi force-pushed unstub-ErrorNotification from e81a358d83 to 1722ef66c5 2025-09-20 18:23:34 +02:00 Compare
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Required
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin unstub-ErrorNotification:unstub-ErrorNotification
git checkout unstub-ErrorNotification
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2500
No description provided.
Delete branch "unstub-ErrorNotification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?