[vk, texture_cache] MSAA ensure no more crash #245

Merged

crueter merged 1 commit from msaa_temp_ex into master

2025-08-13 01:42:57 +02:00

Maufeat commented

2025-08-12 11:39:04 +02:00

Member

The shared_ptr capture ensures the temporary image outlives all queued GPU work (both the upload/download step and the MSAA compute copy). Without this, drivers read freed memory
The temp image always has STORAGE & TRANSFER usage, matching what the compute MSAA path actually binds.
Since this only a temp fix ontop of the previous commit, we only use the MSAA path for color; depth/stencil still use the original safe route.
Should still be reworked though, as seen in the other MSAA commis that are open.

> The shared_ptr<Image> capture ensures the temporary image outlives all queued GPU work (both the upload/download step and the MSAA compute copy). Without this, drivers read freed memory > The temp image always has STORAGE & TRANSFER usage, matching what the compute MSAA path actually binds. > Since this only a temp fix ontop of the previous commit, we only use the MSAA path for color; depth/stencil still use the original safe route. > Should still be reworked though, as seen in the other MSAA commis that are open.

MaranBr force-pushed msaa_temp_ex from e34a9f8738 to 0823ebba80

2025-08-12 21:56:09 +02:00

Compare