eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

Revert image view usage flags regression introduced in 492d3856e8. #241

Merged
Shinmegumi merged 1 commit from weakboson/eden:revert-image-view-usage into master 2025-08-13 15:35:58 +02:00
Conversation 1 Commits 1 Files changed 1 +6 -1
weakboson commented 2025-08-11 19:04:07 +02:00
Contributor
Copy link

Maxwell format VK_FORMAT_A8B8G8R8_SRGB_PACK32 does not support storage. However a A8B8G8R8_UNORM view is created for a image with that format which supports storage. The previous patch ignored image view format usage making it impossible for the pipeline to render to the texture.
This commit reverts the image usage override. However, there is still a mismatch between image format usage and image view format usage.

Maxwell format `VK_FORMAT_A8B8G8R8_SRGB_PACK32` does not support storage. However a `A8B8G8R8_UNORM` view is created for a image with that format which supports storage. The previous patch ignored image view format usage making it impossible for the pipeline to render to the texture. This commit reverts the image usage override. However, there is still a mismatch between image format usage and image view format usage.
weakboson added 1 commit 2025-08-11 19:04:08 +02:00
Revert image view usage flags regression introduced in 492d3856e8.
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
065a7e6866 
Maxwell format `VK_FORMAT_A8B8G8R8_SRGB_PACK32` does not support storage. However a `A8B8G8R8_UNORM` view is created for a image with that format which supports storage. The previous patch ignored image view format usage making it impossible for the pipeline to render to the texture.
This commit reverts the image usage override. However, there is still a mismatch between image format usage and image view format usage.
MaranBr force-pushed revert-image-view-usage from 065a7e6866 to 4ca3746614 2025-08-12 21:55:58 +02:00 Compare
MaranBr force-pushed revert-image-view-usage from 4ca3746614 to 57a9541f58 2025-08-13 15:23:28 +02:00 Compare
requested review from Shinmegumi 2025-08-13 15:23:52 +02:00
Shinmegumi approved these changes 2025-08-13 15:28:16 +02:00
Shinmegumi left a comment
Owner
Copy link

Heavily tested by MaranBR. Can be merged when ready.

Heavily tested by MaranBR. Can be merged when ready.
requested review from CamilleLaVey 2025-08-13 15:33:05 +02:00
Shinmegumi merged commit 383fb23348 into master 2025-08-13 15:35:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
CamilleLaVey
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#241
No description provided.
Delete branch "weakboson/eden:revert-image-view-usage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?