eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[spirv] improved spir-v shader opt #239

Merged
Shinmegumi merged 2 commits from spirv-opt into master 2025-08-15 21:40:41 +02:00
Conversation 6 Commits 2 Files changed 1 +36 -18
crueter commented 2025-08-10 18:57:17 +02:00
Owner
Copy link

increases speed ~tenfold for Spir-V output optimization

Co-authored-by: wildcard nubieluv@gmail.com
Signed-off-by: crueter crueter@eden-emu.dev

increases speed ~tenfold for Spir-V output optimization Co-authored-by: wildcard <nubieluv@gmail.com> Signed-off-by: crueter <crueter@eden-emu.dev>
Lizzie reviewed 2025-08-13 10:08:11 +02:00
src/shader_recompiler/backend/spirv/emit_spirv.cpp Outdated
@ -487,3 +505,4 @@
std::vector<u32> EmitSPIRV(const Profile& profile, const RuntimeInfo& runtime_info,
IR::Program& program, Bindings& bindings, bool optimize) {
EmitContext ctx{profile, runtime_info, program, bindings};
// Reserve capacity for interfaces to reduce allocations
Lizzie commented 2025-08-13 10:08:11 +02:00
Member
Copy link

Do not reserve such a low amount of memory, reserve a whole page ATLEAST (4096 / sizeof(T))

https://www.youtube.com/watch?v=algDLvbl1YY

Do not reserve such a low amount of memory, reserve a whole page ATLEAST (4096 / sizeof(T)) https://www.youtube.com/watch?v=algDLvbl1YY
wildcard commented 2025-08-13 19:06:03 +02:00
Member
Copy link

Yes right I forgot to add the comment //guess, increase or decrease accordingly😆

Yes right I forgot to add the comment //guess, increase or decrease accordingly😆
Shinmegumi added this to the 0.0.3 Release Candidate PRs project 2025-08-13 15:43:12 +02:00
Shinmegumi force-pushed spirv-opt from d3e3467b86 to 458c09e553 2025-08-13 16:08:31 +02:00 Compare
Shinmegumi force-pushed spirv-opt from 458c09e553 to eabcaa2f3e 2025-08-15 20:15:21 +02:00 Compare
Shinmegumi commented 2025-08-15 20:35:54 +02:00
Owner
Copy link

@wildcard, do you want to make the change noted by Lizzie or merge this as is?

@wildcard, do you want to make the change noted by Lizzie or merge this as is?
wildcard commented 2025-08-15 20:41:30 +02:00
Member
Copy link

just remove the reserve completely for now same as the original

just remove the reserve completely for now same as the original
Shinmegumi commented 2025-08-15 21:04:05 +02:00
Owner
Copy link

@wildcard wrote in #239 (comment):

just remove the reserve completely for now same as the original

Do you want to make the change so I can merge?

@wildcard wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/239#issuecomment-1916: > just remove the reserve completely for now same as the original Do you want to make the change so I can merge?
wildcard added 1 commit 2025-08-15 21:26:53 +02:00
Update src/shader_recompiler/backend/spirv/emit_spirv.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
97c0339619
wildcard commented 2025-08-15 21:28:00 +02:00
Member
Copy link

done, removed the reserve

done, removed the reserve
Shinmegumi approved these changes 2025-08-15 21:39:54 +02:00
Shinmegumi left a comment
Owner
Copy link

Approved for merge.

Approved for merge.
Shinmegumi merged commit 09a8fab2a2 into master 2025-08-15 21:40:41 +02:00
Shinmegumi deleted branch spirv-opt 2025-08-15 21:40:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
0.0.3 Release Candidate PRs
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#239
No description provided.
Delete branch "spirv-opt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?