[Vk] FixSampleShading #218

Merged

crueter merged 2 commits from wildcard/eden:FixSampleShading into master

2025-08-15 01:17:39 +02:00

wildcard commented

2025-08-07 19:15:59 +02:00

Member

No description provided.

wildcard added 2 commits 2025-08-07 19:16:00 +02:00

Fix VUID error 02816 c93ba3f4ca

[ VUID-vkCmdPipelineBarrier-dstAccessMask-02816 ] The Vulkan spec states: The dstAccessMask member of each element of pMemoryBarriers must only include access flags that are supported by one or more of the pipeline stages in dstStageMask, as specified in the table of supported access types. Fixes the said validation error.

revert c93ba3f4ca 5a4e0cce21

revert Fix VUID error 02816

[ VUID-vkCmdPipelineBarrier-dstAccessMask-02816 ] The Vulkan spec states: The dstAccessMask member of each element of pMemoryBarriers must only include access flags that are supported by one or more of the pipeline stages in dstStageMask, as specified in the table of supported access types. Fixes the said validation error.

wildcard commented

2025-08-07 19:33:04 +02:00

Author

Member

This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android

Gamer64 commented

2025-08-07 21:56:45 +02:00

Member

@wildcard wrote in #218 (comment):

This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android

What do you think about making a slider or something? How much does the perf decrease too? It's expected to have some performance impact as it's quality focused.

@wildcard wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/218#issuecomment-1485: > This should have a value setting like 0.25, 0.5,etc because 1.0f will cause performance issues on android What do you think about making a slider or something? How much does the perf decrease too? It's expected to have some performance impact as it's quality focused.