eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk, opengl] Prevent GPU draw call if CBUF binding fails (cbuf0 error handling) #2

Merged
Bix merged 2 commits from test2 into master 2025-07-13 19:27:40 +02:00
Conversation 0 Commits 2 Files changed 8 +44 -21
Bix commented 2025-07-05 23:26:42 +02:00 (Migrated from git.bixed.xyz)
Copy link

Add defensive checks to cancel draw calls early if any graphics storage buffer (CBUF) fails to bind properly.

  • Modified BindGraphicsStorageBuffer to return false on invalid buffer ID.,
  • ConfigureImpl (both OpenGL and Vulkan) now propagates binding failure.,
  • Pipeline::Configure returns false if CBUF binding fails.,
  • PrepareDraw cancels rendering if pipeline configuration fails.,

This avoids undefined GPU behavior, draw corruption, or crashes caused by uninitialized or invalid constant buffer (CBUF0) access, particularly in games with faulty or missing shader bindings.
Eden Collaborator: edencollaborator@eden-emu.org
Authored-by: CamilleLaVey camillelavey@eden-emu.org
Signed-off-by: Bix bix@bixed.xyz

Add defensive checks to cancel draw calls early if any graphics storage buffer (CBUF) fails to bind properly. - Modified BindGraphicsStorageBuffer to return false on invalid buffer ID., - ConfigureImpl (both OpenGL and Vulkan) now propagates binding failure., - Pipeline::Configure returns false if CBUF binding fails., - PrepareDraw cancels rendering if pipeline configuration fails., This avoids undefined GPU behavior, draw corruption, or crashes caused by uninitialized or invalid constant buffer (CBUF0) access, particularly in games with faulty or missing shader bindings. Eden Collaborator: <edencollaborator@eden-emu.org> Authored-by: CamilleLaVey <camillelavey@eden-emu.org> Signed-off-by: Bix <bix@bixed.xyz>
crueter changed title from [Pipelines, GL, VK] Prevent GPU draw call if CBUF binding fails (cbuf0 error handling) to [vk, opengl] Prevent GPU draw call if CBUF binding fails (cbuf0 error handling) 2025-07-11 10:06:46 +02:00
crueter force-pushed test2 from 88ff3f9ec8 to 815004411a 2025-07-11 10:06:52 +02:00 Compare
crueter force-pushed test2 from 815004411a to 48db39e067 2025-07-13 03:42:39 +02:00 Compare
crueter force-pushed test2 from 48db39e067 to c916e7fc58 2025-07-13 08:42:34 +02:00 Compare
crueter merged commit c47f6615d3 into master 2025-07-13 19:27:40 +02:00
crueter deleted branch test2 2025-07-13 19:27:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2
No description provided.
Delete branch "test2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?