one shot fix: src_barrier conv before/deconv after ResolveImage

xbzk commented

2025-08-03 19:10:43 +02:00

Member

Satisfies vulkan requirement upon using vkCmdResolveImage. Optimizes image transfer and fixes the rain of UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout in a non intrusive way: Barrier is converted prior to ResolveImage, than is converted back to it's original form. Maybe this is not needed but has no perormance impact either.

Games with immediate impact:

Ninja Gaiden ragebound.

How to test:

In another build, enable gpu debugging, run the game and catch logs containing UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout. There will be exhaustive errors like that, heavily impacting game/log performance.
In this build the error rain is gone.
Since it is a vulkan recommendation, and the barrier is comverted back right after, it should only promove optimization with no drawbacks for other games.

Satisfies vulkan requirement upon using vkCmdResolveImage. Optimizes image transfer and fixes the rain of UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout in a non intrusive way: Barrier is converted prior to ResolveImage, than is converted back to it's original form. Maybe this is not needed but has no perormance impact either. Games with immediate impact: Ninja Gaiden ragebound. How to test: In another build, enable gpu debugging, run the game and catch logs containing UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout. There will be exhaustive errors like that, heavily impacting game/log performance. In this build the error rain is gone. Since it is a vulkan recommendation, and the barrier is comverted back right after, it should only promove optimization with no drawbacks for other games.