eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[core/nvdrv] Fix Random Unmap Memory Clearing #176

Merged
Shinmegumi merged 2 commits from unmapMemory-fix into master 2025-08-14 14:30:09 +02:00
Conversation 2 Commits 2 Files changed 2 +19 -10
SDK-Chan commented 2025-08-01 19:20:19 +02:00
Member
Copy link

Now memory should only be unmapped after it was mapped.
Could eventually fix some graphical errors, and improve performance.

Now memory should only be unmapped after it was mapped. Could eventually fix some graphical errors, and improve performance.
Shinmegumi force-pushed unmapMemory-fix from 2d4678ebfb to 3cd6a362fe 2025-08-02 00:13:44 +02:00 Compare
Shinmegumi reviewed 2025-08-03 03:18:30 +02:00
Shinmegumi left a comment
Owner
Copy link

I found no issues with this on Windows and AMD. All games functioned as expected.

I found no issues with this on Windows and AMD. All games functioned as expected.
crueter force-pushed unmapMemory-fix from 3cd6a362fe to 063b950586 2025-08-05 00:11:58 +02:00 Compare
crueter force-pushed unmapMemory-fix from 063b950586 to 78711aa625 2025-08-08 00:49:17 +02:00 Compare
Shinmegumi force-pushed unmapMemory-fix from 78711aa625 to 217616f499 2025-08-08 22:28:10 +02:00 Compare
Shinmegumi added this to the 0.0.3 Release Candidate PRs project 2025-08-13 15:43:38 +02:00
Shinmegumi force-pushed unmapMemory-fix from 217616f499 to 5da6c83283 2025-08-13 16:09:17 +02:00 Compare
MaranBr force-pushed unmapMemory-fix from 5da6c83283 to 12f98ade10 2025-08-13 20:43:48 +02:00 Compare
Shinmegumi approved these changes 2025-08-14 14:29:31 +02:00
Shinmegumi left a comment
Owner
Copy link

Tested by @MaranBr and these changes do not cause any issues in what he tested.

Tested by @MaranBr and these changes do not cause any issues in what he tested.
Shinmegumi force-pushed unmapMemory-fix from 12f98ade10 to c087ac45f6 2025-08-14 14:29:38 +02:00 Compare
Shinmegumi scheduled this pull request to auto merge when all checks succeed 2025-08-14 14:30:01 +02:00
Shinmegumi merged commit c36cc0d3ee into master 2025-08-14 14:30:09 +02:00
Shinmegumi deleted branch unmapMemory-fix 2025-08-14 14:30:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
0.0.3 Release Candidate PRs
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#176
No description provided.
Delete branch "unmapMemory-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?