eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

Fix inversion of toggle for early fences #175

Merged
Shinmegumi merged 4 commits from fix_early_fences_toggle into master 2025-08-02 00:10:30 +02:00
Conversation 0 Commits 4 Files changed 1 +3 -3
Shinmegumi commented 2025-08-01 19:06:19 +02:00
Owner
Copy link

There was an issue that caused the toggle for this to be reversed on android. Made changes to the if statements to ensure that this works as intended by being on when the toggle is on and off when the toggle is off.

Otherwise, this feature worked as intended.

Made based on recommendations by Xx_Wildcard_xX

Signed-off-by: Shinmegumi shinmegumi@eden-emu.dev

There was an issue that caused the toggle for this to be reversed on android. Made changes to the if statements to ensure that this works as intended by being on when the toggle is on and off when the toggle is off. Otherwise, this feature worked as intended. Made based on recommendations by Xx_Wildcard_xX Signed-off-by: Shinmegumi <shinmegumi@eden-emu.dev>
Shinmegumi added 1 commit 2025-08-01 19:06:20 +02:00
Fix inversion of toggle for early fences
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
e24b83adb9 
This should fix performance regressions in games that didn't need this and fix it to work with the games it is intended to be used for.

Signed-off-by: Shinmegumi <shinmegumi@eden-emu.dev>
Shinmegumi added 1 commit 2025-08-01 19:35:47 +02:00
revert 623baac26b
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
9d3e1998b1 
revert Use NEON intrinsics in Vec4 dot operation

PabloMK7: Changes the Vec4 dot operation to use NEON intrinsics on ARM devices.
This function is used every time a triangle is added to the rendered, so it can be considered hot code. The other vector operations are not used as much, so there is no gain to provide NEON operations for them.

The improvements from this change are most likely minimal.

Co-authored-by: PabloMK7 <hackyglitch2@gmail.com>
Shinmegumi added 1 commit 2025-08-01 22:21:00 +02:00
Forgot a ! on one of the checks.
All checks were successful
eden-license / license-header (pull_request) Successful in 19s
Details
284dc8e337 
Should fix the inversion properly now. Forgot to add a ! operator to one of the button checks for fences button.
Shinmegumi merged commit 45e7c0d62d into master 2025-08-02 00:10:30 +02:00
Shinmegumi deleted branch fix_early_fences_toggle 2025-08-02 00:10:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#175
No description provided.
Delete branch "fix_early_fences_toggle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?