eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Remove improper check for image depth in texture cache. #164

Merged
Shinmegumi merged 2 commits from weakboson/eden:remove-improper-depth-check-texture-cache into master 2025-07-31 17:47:29 +02:00
Conversation 0 Commits 2 Files changed 2 +8 -4
weakboson commented 2025-07-30 19:13:28 +02:00
Contributor
Copy link

When looking for existing images, ImageBase::TryFindBase checks the depth of the existing image to be greater than the layer of the base + depth of the candidate.
However the depth of images are not updated when cache were merged causing the lookup to fail.
This commit disables this faulty check to fix a critical memory leak that crashes the emulator in some games.

When looking for existing images, ImageBase::TryFindBase checks the depth of the existing image to be greater than the layer of the base + depth of the candidate. However the depth of images are not updated when cache were merged causing the lookup to fail. This commit disables this faulty check to fix a critical memory leak that crashes the emulator in some games.
crueter changed title from [vk] Remove improper check for image depth in texture cache. to WIP: [vk] Remove improper check for image depth in texture cache. 2025-07-31 16:54:42 +02:00
Shinmegumi changed title from WIP: [vk] Remove improper check for image depth in texture cache. to [vk] Remove improper check for image depth in texture cache. 2025-07-31 17:46:58 +02:00
Shinmegumi force-pushed remove-improper-depth-check-texture-cache from 4f662e42fa to 466503adbe 2025-07-31 17:47:06 +02:00 Compare
Shinmegumi merged commit 6fd10fd85e into master 2025-07-31 17:47:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#164
No description provided.
Delete branch "weakboson/eden:remove-improper-depth-check-texture-cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?