eden-emu/eden
25
3
Fork 18
Code Issues 88 Pull requests 69 Projects 1 Releases 7 Wiki Activity Actions

WIP: [vk, msaa] Rewrite MSAA texture upload/download handling #133

Draft
MrPurple666 wants to merge 1 commit from MrPurple666/eden:msaa-new into master
pull from: MrPurple666/eden:msaa-new
merge into: eden-emu:master
Conversation 1 Commits 1 Files changed 1 +182 -137
MrPurple666 commented 2025-07-26 08:40:12 +02:00
Owner
Copy link

This pull request significantly improves the robustness and flexibility of MSAA texture handling in the Vulkan backend. It replaces the previous MSAACopyPass-based method, which relied on limited and unstable logic, with an explicit and well-defined blit path that leverages Vulkan’s transfer and layout semantics. During texture uploads, MSAA images now receive data via an intermediate non-MSAA image followed by a vkCmdBlitImage operation, ensuring compliance with Vulkan’s constraints and providing a generalized solution for various image formats. Likewise, for downloads, the process is reversed: MSAA images are blitted into a temporary non-MSAA image before copying to the target buffer. Layout transitions and synchronization are handled with explicit barriers, enhancing clarity and correctness. This approach not only improves reliability and maintainability but also sets the foundation for supporting more complex formats like depth/stencil in future work. Furthermore, a minor change ensures that images flagged for storage use are initialized with a standard RGBA swizzle to avoid undefined shader behavior.

PS: Tested on Android only.

This pull request significantly improves the robustness and flexibility of MSAA texture handling in the Vulkan backend. It replaces the previous MSAACopyPass-based method, which relied on limited and unstable logic, with an explicit and well-defined blit path that leverages Vulkan’s transfer and layout semantics. During texture uploads, MSAA images now receive data via an intermediate non-MSAA image followed by a vkCmdBlitImage operation, ensuring compliance with Vulkan’s constraints and providing a generalized solution for various image formats. Likewise, for downloads, the process is reversed: MSAA images are blitted into a temporary non-MSAA image before copying to the target buffer. Layout transitions and synchronization are handled with explicit barriers, enhancing clarity and correctness. This approach not only improves reliability and maintainability but also sets the foundation for supporting more complex formats like depth/stencil in future work. Furthermore, a minor change ensures that images flagged for storage use are initialized with a standard RGBA swizzle to avoid undefined shader behavior. PS: Tested on Android only.
Shinmegumi force-pushed msaa-new from 9be971f59b
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
to 7672704731
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
2025-07-26 23:21:12 +02:00 Compare
MaranBr force-pushed msaa-new from 7672704731
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
to e8c49be369
Some checks failed
eden-license / license-header (pull_request) Failing after 29s
Details
2025-07-27 02:26:24 +02:00 Compare
Shinmegumi force-pushed msaa-new from e8c49be369
Some checks failed
eden-license / license-header (pull_request) Failing after 29s
Details
to e12a500720
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
2025-08-02 00:11:15 +02:00 Compare
crueter force-pushed msaa-new from e12a500720
Some checks failed
eden-license / license-header (pull_request) Has been cancelled
Details
to 55c1b9ddcd
All checks were successful
eden-license / license-header (pull_request) Successful in 14s
Details
2025-08-03 01:57:37 +02:00 Compare
crueter force-pushed msaa-new from 55c1b9ddcd
All checks were successful
eden-license / license-header (pull_request) Successful in 14s
Details
to f6b227ebfd
Some checks failed
eden-license / license-header (pull_request) Successful in 37s
Details
build.yml / vk_texture_cache: Rewrite MSAA handling with blits and proper barriers (pull_request) Failing after 0s
Details
trigger_release.yml / vk_texture_cache: Rewrite MSAA handling with blits and proper barriers (pull_request) Failing after 0s
Details
2025-08-04 23:56:58 +02:00 Compare
DraVee commented 2025-10-26 03:05:03 +01:00
Member
Copy link

Can you sync it?

Can you sync it?
DraVee changed title from [vk, msaa] Rewrite MSAA texture upload/download handling to WIP: [vk, msaa] Rewrite MSAA texture upload/download handling 2025-11-27 03:08:38 +01:00
Some checks failed
eden-license / license-header (pull_request) Successful in 37s
Required
Details
build.yml / vk_texture_cache: Rewrite MSAA handling with blits and proper barriers (pull_request) Failing after 0s
Details
trigger_release.yml / vk_texture_cache: Rewrite MSAA handling with blits and proper barriers (pull_request) Failing after 0s
Details
This pull request has changes conflicting with the target branch.
  • src/video_core/renderer_vulkan/vk_texture_cache.cpp
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u msaa-new:MrPurple666-msaa-new
git switch MrPurple666-msaa-new
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!133
No description provided.