eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Fix query cache leak on missed sync #131

Merged
CamilleLaVey merged 1 commit from fix-query-cache-leak-on-missed-sync into master 2025-07-26 18:12:55 +02:00
Conversation 0 Commits 1 Files changed 4 +82 -98
Shinmegumi commented 2025-07-25 15:58:44 +02:00
Owner
Copy link

Provided by community member, elementary-particle. Submitted as PR by MaranBR.

Fixed issues:

  1. The queue cache forgot to put the host query into unregister queue if they weren't synced. This will block all the banks from freeing causing a major leak.

  2. SamplesQueryCounter is not aligned with renderpass begin/end. This creates invalid queries.

  3. Conditional rendering is not turned on/off at the correct location making them invalid.

Provided by community member, elementary-particle. Submitted as PR by MaranBR. Fixed issues: 1. The queue cache forgot to put the host query into unregister queue if they weren't synced. This will block all the banks from freeing causing a major leak. 2. SamplesQueryCounter is not aligned with renderpass begin/end. This creates invalid queries. 3. Conditional rendering is not turned on/off at the correct location making them invalid.
Shinmegumi added the
core
graphics
 labels 2025-07-25 15:58:44 +02:00
requested reviews from crueter, CamilleLaVey 2025-07-25 15:59:28 +02:00
removed review requests for crueter, CamilleLaVey 2025-07-25 16:06:11 +02:00
MaranBr was assigned by Shinmegumi 2025-07-25 16:06:26 +02:00
Shinmegumi self-assigned this 2025-07-25 16:06:27 +02:00
MaranBr force-pushed fix-query-cache-leak-on-missed-sync from 5381747cda to 403c63d740 2025-07-25 21:23:41 +02:00 Compare
MaranBr force-pushed fix-query-cache-leak-on-missed-sync from 403c63d740 to 3f46fad878 2025-07-25 21:34:53 +02:00 Compare
Maufeat force-pushed fix-query-cache-leak-on-missed-sync from 3f46fad878 to 6c3ebcc0cb 2025-07-26 12:56:20 +02:00 Compare
Maufeat force-pushed fix-query-cache-leak-on-missed-sync from 6c3ebcc0cb to c7c2ed7b46 2025-07-26 13:16:15 +02:00 Compare
Maufeat added 1 commit 2025-07-26 13:17:02 +02:00
add fixes by elementary particle v2
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
8e9ef8303f
CamilleLaVey merged commit b1f3b568fb into master 2025-07-26 18:12:55 +02:00
CamilleLaVey deleted branch fix-query-cache-leak-on-missed-sync 2025-07-26 18:12:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
MaranBr
Shinmegumi
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#131
No description provided.
Delete branch "fix-query-cache-leak-on-missed-sync"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?