eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[qt] refactor: qt_common lib #94

Merged
crueter merged 53 commits from refactor/qt_common into master 2025-09-15 17:21:19 +02:00
Conversation 5 Commits 53 Files changed 111 +2235 -1544
crueter commented 2025-07-22 23:06:45 +02:00
Owner
Copy link

This is part of a series of PRs made in preparation for the QML rewrite. this PR specifically moves a bunch of utility functions from main.cpp into qt_common, with the biggest benefit being that QML can reuse the exact same code through ctx passthrough.

Also, QtCommon::Frontend is an abstraction layer over several previously Widgets-specific stuff like QMessageBox that gets used everywhere. The idea is that once QML is implemented, these functions can have a Quick version implemented for systems that don't work well with Widgets (sun) or for those on Plasma 6+ (reduces memory usage w/o Widgets linkage) although Quick from C++ is actually anal, but whatever.

Other than that this should also just kinda reduce the size of main.cpp which is a 6000-line behemoth rn, and clangd straight up gives up with it for me (likely caused by the massive amount of headers, which this DOES reduce).

In the future, I probably want to create a common strings lookup table that both Qt and QML can reference--though I'm not sure how much linguist likes that--which should give us a way to keep language consistent (use frozen-map).

TODO:

  • Docs for Qt stuff
This is part of a series of PRs made in preparation for the QML rewrite. this PR specifically moves a bunch of utility functions from main.cpp into qt_common, with the biggest benefit being that QML can reuse the exact same code through ctx passthrough. Also, QtCommon::Frontend is an abstraction layer over several previously Widgets-specific stuff like QMessageBox that gets used everywhere. The idea is that once QML is implemented, these functions can have a Quick version implemented for systems that don't work well with Widgets (sun) or for those on Plasma 6+ (reduces memory usage w/o Widgets linkage) although Quick from C++ is actually anal, but whatever. Other than that this should also just kinda reduce the size of main.cpp which is a 6000-line behemoth rn, and clangd straight up gives up with it for me (likely caused by the massive amount of headers, which this DOES reduce). In the future, I probably want to create a common strings lookup table that both Qt and QML can reference--though I'm not sure how much linguist likes that--which should give us a way to keep language consistent (use frozen-map). TODO: - [ ] Docs for Qt stuff
crueter changed title from [qt] Separate qt_common with common Desktop functionality to [qt] refactor: qt_common lib 2025-07-22 23:14:09 +02:00
crueter force-pushed refactor/qt_common from 60c967ddbb to 0f28ecbe71 2025-07-23 19:21:39 +02:00 Compare
crueter changed title from [qt] refactor: qt_common lib to WIP: [qt] refactor: qt_common lib 2025-07-24 03:11:27 +02:00
crueter force-pushed refactor/qt_common from 490758c2ce to 6f5a012cb3 2025-08-08 02:35:22 +02:00 Compare
crueter added 1 commit 2025-08-08 02:45:37 +02:00
[qt_common] update translations
All checks were successful
eden-license / license-header (pull_request) Successful in 14s
Details
b817441c0f 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter force-pushed refactor/qt_common from b817441c0f to e5ca953f59 2025-08-31 00:20:28 +02:00 Compare
crueter added 1 commit 2025-08-31 01:48:17 +02:00
[qt_common] reorg, move more stuff out of main
Some checks failed
eden-license / license-header (pull_request) Failing after 30s
Details
d9cbb6f0a4 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-31 01:50:02 +02:00
Fix license headers
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
0071bf54d5
crueter force-pushed refactor/qt_common from 0071bf54d5 to d111dcecd0 2025-08-31 01:50:57 +02:00 Compare
crueter added 1 commit 2025-08-31 01:54:45 +02:00
cleanup
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
0f503b0075 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-31 02:08:30 +02:00
fix win
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
cbc626fc70 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-31 02:30:15 +02:00
fix
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
f05856961a 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-31 20:56:52 +02:00
better handling for sys/vfs/rootobject
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
2142082905 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-08-31 20:57:17 +02:00
Fix license headers
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
dcf491fded
crueter force-pushed refactor/qt_common from dcf491fded to 2d94767f96 2025-09-13 16:25:49 +02:00 Compare
crueter added 1 commit 2025-09-13 17:39:14 +02:00
QProgressDialog abstractor, more moving
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
8974aed013 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter changed title from WIP: [qt] refactor: qt_common lib to [qt] refactor: qt_common lib 2025-09-13 17:39:42 +02:00
crueter added 1 commit 2025-09-13 17:47:25 +02:00
fix headers
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
b326f2e3e0 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter commented 2025-09-13 17:47:50 +02:00
Author
Owner
Copy link

This PR is still technically incomplete, but it's such a massive PR at this point that I think I'm done with it for the time being. Further work can be done as-needed in the QML frontend

This PR is still technically incomplete, but it's such a massive PR at this point that I think I'm done with it for the time being. Further work can be done as-needed in the QML frontend
crueter added 1 commit 2025-09-13 17:49:00 +02:00
Fix cpm-fetch
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
c70d9140a4 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-09-13 17:51:36 +02:00
fix cpm-fetch (again)
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
63961f3741 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-09-13 18:09:03 +02:00
fix msvc
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
ae31504772 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-09-13 18:28:49 +02:00
fix windows
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
a572ee58d3 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-09-13 19:31:26 +02:00
fix windows dir opening
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
6d7820cf01 
Signed-off-by: crueter <crueter@eden-emu.dev>
MaranBr approved these changes 2025-09-15 15:33:09 +02:00
Dismissed
Shinmegumi approved these changes 2025-09-15 16:09:15 +02:00
Dismissed
MaranBr force-pushed refactor/qt_common from 6d7820cf01 to 33a203159b 2025-09-15 16:28:57 +02:00 Compare
MaranBr dismissed MaranBr's review 2025-09-15 16:28:58 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr dismissed Shinmegumi's review 2025-09-15 16:28:58 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

MaranBr added 27 commits 2025-09-15 16:43:21 +02:00 
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@crueter.xyz>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Signed-off-by: crueter <crueter@eden-emu.dev>
Fix license headers
Some checks failed
eden-license / license-header (pull_request) Failing after 34s
Details
2d94767f96
QProgressDialog abstractor, more moving
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
8974aed013 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix headers
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
b326f2e3e0 
Signed-off-by: crueter <crueter@eden-emu.dev>
Fix cpm-fetch
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
c70d9140a4 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix cpm-fetch (again)
All checks were successful
eden-license / license-header (pull_request) Successful in 35s
Details
63961f3741 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix msvc
All checks were successful
eden-license / license-header (pull_request) Successful in 34s
Details
ae31504772 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix windows
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
a572ee58d3 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix windows dir opening
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
6d7820cf01 
Signed-off-by: crueter <crueter@eden-emu.dev>
Minor clean up
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
23f3a3d2e3
MaranBr added 1 commit 2025-09-15 16:46:54 +02:00
Remove remaining file
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
65bc0364bd
MaranBr approved these changes 2025-09-15 16:49:30 +02:00
Shinmegumi approved these changes 2025-09-15 16:51:38 +02:00
crueter merged commit f4386423e8 into master 2025-09-15 17:21:19 +02:00
crueter referenced this pull request from a commit 2025-09-15 17:21:19 +02:00
[qt] refactor: qt_common lib (#94)
crueter deleted branch refactor/qt_common 2025-09-15 17:21:20 +02:00
crueter referenced this pull request from a commit 2025-09-17 02:37:47 +02:00
[qt] refactor: qt_common lib (#94)
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#94
No description provided.
Delete branch "refactor/qt_common"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?