eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[svc, audio] Implement REV13 audio renderer support and stub IAudioDevice commands up to 18.0.0+ #92

Closed
JPikachu wants to merge 2 commits from REV-13 into master
pull from: REV-13
merge into: eden-emu:master
Conversation 1 Commits 2 Files changed 10 +170 -11
JPikachu commented 2025-07-22 16:06:17 +02:00
Member
Copy link

Fully implements support for the AudioRenderer REV13 interface.

  • Adds SplitterDestinationInParameter with reset_prev_volume support.
  • Updates SplitterContext to parse REV13 destination parameters.
  • Handles per-destination volume ramp resets.
  • Verified against Ryujinx commit:
    a2c0035013

Stubs new commands in IAudioDevice introduced in 17.0.0+ and 18.0.0+:

  • Command 15: AcquireAudioInputDeviceNotification()
  • Command 16: ReleaseAudioInputDeviceNotification()
  • Command 17: AcquireAudioOutputDeviceNotification()
  • Command 18: ReleaseAudioOutputDeviceNotification()
  • Command 19: SetAudioDeviceOutputVolumeAutoTuneEnabled()
  • Command 20: IsAudioDeviceOutputVolumeAutoTuneEnabled()
    These were referenced directly from Ryujinx too.

Should fix audio reset issues in The Legend of Zelda: Echoes of Wisdom.
Note: due to minimal documentation on the audio services some guess work has been made and it may not be 100% accuracte to the switch's services.

Fully implements support for the AudioRenderer REV13 interface. - Adds SplitterDestinationInParameter with `reset_prev_volume` support. - Updates SplitterContext to parse REV13 destination parameters. - Handles per-destination volume ramp resets. - Verified against Ryujinx commit: https://git.bixed.xyz/Bix/Ryujinx/commit/a2c003501371463fd1f98d2e5a7602ae19c21d7c Stubs new commands in IAudioDevice introduced in 17.0.0+ and 18.0.0+: - Command 15: AcquireAudioInputDeviceNotification() - Command 16: ReleaseAudioInputDeviceNotification() - Command 17: AcquireAudioOutputDeviceNotification() - Command 18: ReleaseAudioOutputDeviceNotification() - Command 19: SetAudioDeviceOutputVolumeAutoTuneEnabled() - Command 20: IsAudioDeviceOutputVolumeAutoTuneEnabled() These were referenced directly from Ryujinx too. Should fix audio reset issues in The Legend of Zelda: Echoes of Wisdom. Note: due to minimal documentation on the audio services some guess work has been made and it may not be 100% accuracte to the switch's services.
crueter force-pushed REV-13 from a536072cad to 092b483104 2025-08-03 01:57:45 +02:00 Compare
JPikachu commented 2025-09-22 13:37:41 +02:00
Author
Member
Copy link

Didn't work, needs a re do another time 😅

Didn't work, needs a re do another time 😅
JPikachu closed this pull request 2025-09-22 13:37:41 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 18s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#92
No description provided.
Delete branch "REV-13"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?