eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[ci, docs] Refactor building with Windows #400

Merged
crueter merged 3 commits from DraVee/eden:ci/windows-installer into master 2025-09-12 16:07:36 +02:00
Conversation 6 Commits 3 Files changed 3 +212 -98
DraVee commented 2025-09-10 01:25:03 +02:00
Member
Copy link
  • this a initial PR to improve documentation of building under windows
* this a initial PR to improve documentation of building under windows
crueter reviewed 2025-09-10 02:20:33 +02:00
crueter left a comment
Owner
Copy link

Looks mostly good for now; I plan a larger rewrite at some point soon

Looks mostly good for now; I plan a larger rewrite at some point soon
.ci/windows/install-msvc.ps1 Outdated
@ -0,0 +46,4 @@
$VSPath = Join-Path $VSROOT "VC\Tools\MSVC"
Write-Host "Adding Visual Studio paths to GitHub Actions environment"
echo "$VSPath\bin\Hostx64\x64" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
}
crueter commented 2025-09-10 02:19:21 +02:00
Owner
Copy link

This probably isn't needed tbh--GitHub actions will just use ilammy's action

This probably isn't needed tbh--GitHub actions will just use ilammy's action
DraVee commented 2025-09-10 03:10:04 +02:00
Author
Member
Copy link

Removed on fc860112a58033123a3d8a9de4c7cb47b1f091e2
I based this on VulkanSDK, not sure it was there but ok XD

Removed on fc860112a58033123a3d8a9de4c7cb47b1f091e2 I based this on VulkanSDK, not sure it was there but ok XD
DraVee marked this conversation as resolved
DraVee force-pushed ci/windows-installer from c42caefcdd to fc860112a5 2025-09-10 03:08:51 +02:00 Compare
crueter approved these changes 2025-09-10 18:37:34 +02:00
Dismissed
MaranBr approved these changes 2025-09-10 18:38:08 +02:00
DraVee commented 2025-09-10 20:58:37 +02:00
Author
Member
Copy link

@crueter wrote in #400 (comment):

Looks mostly good for now; I plan a larger rewrite at some point soon

I will do some rewrite too, just to see what's still useful/working

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/400#issuecomment-3375: > Looks mostly good for now; I plan a larger rewrite at some point soon I will do some rewrite too, just to see what's still useful/working
MaranBr force-pushed ci/windows-installer from fc860112a5 to 9cc1df3fba 2025-09-10 22:23:17 +02:00 Compare
Shinmegumi force-pushed ci/windows-installer from 9cc1df3fba to 036fe8b4b6 2025-09-12 16:06:43 +02:00 Compare
crueter approved these changes 2025-09-12 16:07:07 +02:00
Shinmegumi approved these changes 2025-09-12 16:07:18 +02:00
crueter merged commit 28d26b0d76 into master 2025-09-12 16:07:36 +02:00
crueter deleted branch ci/windows-installer 2025-09-12 16:07:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
crueter
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#400
No description provided.
Delete branch "DraVee/eden:ci/windows-installer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?