eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[hle] Stubbed QueryLastPlayTime #389

Merged
MaranBr merged 2 commits from last-play-time-stub into master 2025-10-08 02:08:14 +02:00
Conversation 5 Commits 2 Files changed 2 +21 -1
Gamer64 commented 2025-09-06 15:16:23 +02:00
Member
Copy link

Ported from Torzu, made by Jarrod Norwell.

Co-authored-by: Jarrod Norwell official.antique@gmail.com

Ported from Torzu, made by Jarrod Norwell. Co-authored-by: Jarrod Norwell <official.antique@gmail.com>
Gamer64 added 1 commit 2025-09-06 15:16:24 +02:00
Stubbed QueryLastPlayTime
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
8e56372860 
Co-authored-by: Jarrod Norwell <official.antique@gmail.com>
Gamer64 added 1 commit 2025-09-06 15:32:20 +02:00
annoying
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
13e6d63c12
Gamer64 changed title from [query_service]: Stubbed QueryLastPlayTime to [HLE] [Torzu]: Stubbed QueryLastPlayTime 2025-09-06 15:37:43 +02:00
MaranBr changed title from [HLE] [Torzu]: Stubbed QueryLastPlayTime to [hle] Stubbed QueryLastPlayTime 2025-09-07 22:51:00 +02:00
MaranBr approved these changes 2025-09-07 22:51:42 +02:00
Dismissed
crueter approved these changes 2025-09-08 00:39:15 +02:00
MaranBr requested changes 2025-09-08 19:28:45 +02:00
Dismissed
src/core/hle/service/ns/query_service.cpp Outdated
@ -56,0 +60,4 @@
Out<s32> out_entries, u8 unknown,
OutArray<LastPlayTime, BufferAttr_HipcMapAlias> out_last_play_times,
InArray<s32, BufferAttr_HipcMapAlias> application_ids) {
*out_entries = 1;
MaranBr commented 2025-09-08 14:31:53 +02:00
Member
Copy link

In Sudachi, *out_entries is set to 0. Any reason why this value was changed to 1?

In Sudachi, *out_entries is set to 0. Any reason why this value was changed to 1?
Gamer64 commented 2025-09-09 16:11:20 +02:00
Author
Member
Copy link

It is a backport from 66ae161cf8, where it is 1, but I can change it to 0 if required. Maybe it got changed to prevent possible crashes coming from a possible mem acces violation if it was set to 0.

It is a backport from https://github.com/ong19th/Torzu/commit/66ae161cf879aaa6800c13d8a5144e96815a2385, where it is 1, but I can change it to 0 if required. Maybe it got changed to prevent possible crashes coming from a possible mem acces violation if it was set to 0.
MaranBr commented 2025-09-10 02:45:04 +02:00
Member
Copy link

Interesting. In Sudachi 1.0.15 this value is set to 0.

Interesting. In Sudachi 1.0.15 this value is set to 0.
MaranBr force-pushed last-play-time-stub from 13e6d63c12 to 47b5b8d98c 2025-09-12 03:13:41 +02:00 Compare
MaranBr force-pushed last-play-time-stub from 47b5b8d98c to 505facd23e 2025-09-24 22:22:25 +02:00 Compare
MaranBr approved these changes 2025-09-24 22:22:36 +02:00
MaranBr force-pushed last-play-time-stub from 505facd23e to e03f1c37bd 2025-09-28 16:34:40 +02:00 Compare
DraVee approved these changes 2025-09-28 16:59:39 +02:00
Shinmegumi force-pushed last-play-time-stub from e03f1c37bd to c55cc119fe 2025-09-28 18:44:21 +02:00 Compare
MaranBr merged commit acd7d792a3 into master 2025-10-08 02:08:14 +02:00
MaranBr deleted branch last-play-time-stub 2025-10-08 02:08:14 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
crueter
MaranBr
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#389
No description provided.
Delete branch "last-play-time-stub"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?