eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 55 Projects 1 Releases Packages Wiki Activity Actions

[frontend] refactor: extract common firmware & key functions #38

Merged
crueter merged 4 commits from feature/firmware-loader into master 2025-07-13 03:39:21 +02:00
Conversation 0 Commits 4 Files changed 39 +1146 -1078
crueter commented 2025-07-11 01:56:33 +02:00
Owner
Copy link

Extracts some firmware version/verification functions into
frontend_common to reduce duplicate code, especially for the new QML
frontend.

Additionally adds a check for games that are known to require firmware
(e.g. MK8DX) and warns the user if they don't have firmware installed
and attempt to run the game.

Firmware installation is to be in a separate PR.

Signed-off-by: crueter crueter@eden-emu.dev

Extracts some firmware version/verification functions into `frontend_common` to reduce duplicate code, especially for the new QML frontend. Additionally adds a check for games that are known to require firmware (e.g. MK8DX) and warns the user if they don't have firmware installed and attempt to run the game. Firmware installation is to be in a separate PR. Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-07-11 01:56:34 +02:00
[frontend] refactor: extract common firmware & key functions
Some checks failed
eden-license / license-header (pull_request) Failing after 16s
Details
d702d6d7bf 
Extracts some firmware version/verification functions into
`frontend_common` to reduce duplicate code, especially for the new QML
frontend.

Additionally adds a check for games that are known to require firmware
(e.g. MK8DX) and warns the user if they don't have firmware installed
and attempt to run the game.

This also makes it easier for us to implement parallel installations in
the future.

TODO:
- [ ] Properly implement installDecryptionKeys on Android
- [ ] Deal with amiibo keys :/
- [ ] Properly implement firmware checker on Android
- [ ] Implement firmware install/uninstall
  * [ ] Implement install from zip

Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-07-11 05:52:47 +02:00
Implement firmware game checker on Android
All checks were successful
eden-license / license-header (pull_request) Successful in 15s
Details
67edb897bf 
Signed-off-by: crueter <crueter@eden-emu.dev>
AleksandrPopovich added 1 commit 2025-07-12 06:05:30 +02:00
[android] move the key processor to firmware_manager
All checks were successful
eden-license / license-header (pull_request) Successful in 13s
Details
a360f67fad 
Signed-off-by: Aleksandr Popovich <popovich@eden-emu.dev>
AleksandrPopovich added 1 commit 2025-07-12 06:14:39 +02:00
[frontend_common] Fix unnecessary includes for non android
All checks were successful
eden-license / license-header (pull_request) Successful in 16s
Details
ae4807bc77 
Signed-off-by: Aleksandr Popovich <popovich@eden-emu.dev>
crueter changed title from WIP: [frontend] refactor: extract common firmware & key functions to [frontend] refactor: extract common firmware & key functions 2025-07-12 22:07:32 +02:00
crueter merged commit 03351a4f8b into master 2025-07-13 03:39:21 +02:00
crueter deleted branch feature/firmware-loader 2025-07-13 03:39:21 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#38
No description provided.
Delete branch "feature/firmware-loader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?