eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 75 Projects 1 Releases 7 Wiki Activity Actions

[gamemode] Make available on other platforms #353

Merged
DraVee merged 18 commits from liz-gamemode-flatten into master 2025-12-07 07:13:44 +01:00
Conversation 9 Commits 18 Files changed 29 +123 -775
Lizzie commented 2025-08-30 01:46:09 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed liz-gamemode-flatten from 3183f51e1f
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
to 385debd86b
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
2025-08-30 01:48:42 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from eae7801d0f
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
to b19a9bced6
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-08-30 07:57:01 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from b19a9bced6
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 26db1fb807
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
2025-08-30 10:44:11 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 26db1fb807
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
to 012d0d48ae
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
2025-08-30 15:39:40 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 012d0d48ae
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
to 05db2ae62f
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
2025-08-30 15:41:21 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 05db2ae62f
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
to a39181a370
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
2025-08-31 05:13:18 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from a39181a370
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
to 769403dfe5
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-09-06 10:06:42 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 769403dfe5
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to bb58b73fe5
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
2025-09-09 05:17:16 +02:00 Compare
crueter requested changes 2025-09-09 05:50:37 +02:00
crueter left a comment
Owner
Copy link

We should also move the gamemode option elsewhere in the UI maybe

We should also move the gamemode option elsewhere in the UI maybe
externals/gamemode/gamemode_client.h Outdated
@ -1,3 +4,3 @@
/*
Copyright (c) 2017-2019, Feral Interactive
Copyright (c) 2017-2025, Feral Interactive and the GameMode contributors
crueter commented 2025-09-09 05:50:06 +02:00
Owner
Copy link

Should this be vendored?

Should this be vendored?
Lizzie commented 2025-09-09 05:51:36 +02:00
Author
Member
Copy link

Feral interactive has updated gamemode a total of 1 time ever since the emu came out.
Feel free to vendor it with CMake magic - I'm unsure how through

Feral interactive has updated gamemode a total of 1 time ever since the emu came out. Feel free to vendor it with CMake magic - I'm unsure how through
crueter commented 2025-09-09 05:53:50 +02:00
Owner
Copy link

Send me the link to where you got it and I'll vendor it tomorrow

Send me the link to where you got it and I'll vendor it tomorrow
Lizzie commented 2025-09-09 05:55:20 +02:00
Author
Member
Copy link

@crueter wrote in #353 (comment):

Send me the link to where you got it and I'll vendor it tomorrow

https://github.com/FeralInteractive/gamemode/blob/master/lib/gamemode_client.h

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/353#issuecomment-3312: > Send me the link to where you got it and I'll vendor it tomorrow https://github.com/FeralInteractive/gamemode/blob/master/lib/gamemode_client.h
Lizzie force-pushed liz-gamemode-flatten from bb58b73fe5
All checks were successful
eden-license / license-header (pull_request) Successful in 33s
Details
to 5772537164
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
2025-09-13 22:49:09 +02:00 Compare
Shinmegumi commented 2025-09-15 17:00:14 +02:00
Owner
Copy link

@crueter, has this change been done to have this vendored so this can be merged? Since it only really affects BSD and such, it should be safe to merge. Will approve if the change has been made for this to be included in CMake properly.

@crueter, has this change been done to have this vendored so this can be merged? Since it only really affects BSD and such, it should be safe to merge. Will approve if the change has been made for this to be included in CMake properly.
Shinmegumi force-pushed liz-gamemode-flatten from 5772537164
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
to 63b9d22235
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
2025-09-15 17:00:20 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 63b9d22235
All checks were successful
eden-license / license-header (pull_request) Successful in 36s
Details
to e662fe99ac
Some checks failed
eden-license / license-header (pull_request) Failing after 16s
Details
2025-09-19 08:56:50 +02:00 Compare
Shinmegumi approved these changes 2025-09-20 17:30:46 +02:00
Dismissed
crueter force-pushed liz-gamemode-flatten from e662fe99ac
Some checks failed
eden-license / license-header (pull_request) Failing after 16s
Details
to 0bd4f2bbd2
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
2025-09-27 01:30:30 +02:00 Compare
crueter dismissed Shinmegumi's review 2025-09-27 01:30:31 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed liz-gamemode-flatten from 0bd4f2bbd2
Some checks failed
eden-license / license-header (pull_request) Failing after 24s
Details
to 929de88588
Some checks failed
eden-license / license-header (pull_request) Failing after 21s
Details
2025-09-29 06:42:02 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 33a1355caa
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to eac3addacc
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2025-09-29 18:54:50 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from eac3addacc
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to a6ad57078c
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
2025-09-30 10:35:44 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from a6ad57078c
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
to 8d8a3164af
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-10-11 02:02:05 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from 8d8a3164af
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to c1c59abc95
Some checks failed
eden-license / license-header (pull_request) Successful in 35s
Details
GitHub Actions [CI] Build failed
Details
2025-10-23 11:43:08 +02:00 Compare
Lizzie force-pushed liz-gamemode-flatten from c1c59abc95
Some checks failed
eden-license / license-header (pull_request) Successful in 35s
Details
GitHub Actions [CI] Build failed
Details
to a4c05fc4ff
Some checks failed
eden-license / license-header (pull_request) Successful in 40s
Details
GitHub Actions [CI] Build failed
Details
2025-10-30 20:34:06 +01:00 Compare
Lizzie force-pushed liz-gamemode-flatten from a4c05fc4ff
Some checks failed
eden-license / license-header (pull_request) Successful in 40s
Details
GitHub Actions [CI] Build failed
Details
to f7c5aa7536
Some checks failed
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build failed
Details
2025-11-07 04:30:15 +01:00 Compare
Lizzie force-pushed liz-gamemode-flatten from f7c5aa7536
Some checks failed
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build failed
Details
to fb49eeabe7
Some checks failed
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build failed
Details
2025-11-12 12:09:54 +01:00 Compare
DraVee reviewed 2025-11-13 03:14:00 +01:00
src/yuzu/main.cpp Outdated
@ -125,1 +125,3 @@
#elif defined(__unix__) && !defined(__ANDROID__)
#endif
#ifdef __unix__
DraVee commented 2025-11-13 03:14:00 +01:00
Member
Copy link

Shouldn't keep !defined(__ANDROID__)?

Shouldn't keep `!defined(__ANDROID__)`?
Lizzie commented 2025-11-24 09:29:04 +01:00
Author
Member
Copy link

ALL unixes, even android

ALL unixes, even android
DraVee marked this conversation as resolved
DraVee reviewed 2025-11-13 03:14:54 +01:00
src/common/settings_common.h Outdated
@ -44,7 +47,6 @@ enum class Category : u32 {
Multiplayer,
Services,
Paths,
Linux,
DraVee commented 2025-11-13 03:14:53 +01:00
Member
Copy link

Still being used by "Force X11"

Still being used by "Force X11"
Lizzie marked this conversation as resolved
Lizzie force-pushed liz-gamemode-flatten from fb49eeabe7
Some checks failed
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build failed
Details
to c29b816818
Some checks failed
eden-license / license-header (pull_request) Successful in 42s
Details
GitHub Actions [CI] Build failed
Details
2025-11-24 06:37:42 +01:00 Compare
Lizzie force-pushed liz-gamemode-flatten from c29b816818
Some checks failed
eden-license / license-header (pull_request) Successful in 42s
Details
GitHub Actions [CI] Build failed
Details
to 0d9c76c963
Some checks reported errors
eden-license / license-header (pull_request) Successful in 44s
Details
GitHub Actions [CI] Build cancelled
Details
2025-11-24 10:14:11 +01:00 Compare
fx
Some checks failed
eden-license / license-header (pull_request) Successful in 42s
Details
GitHub Actions [CI] Build failed
Details
044e24fd21
Lizzie commented 2025-11-25 10:34:30 +01:00
Author
Member
Copy link

todo: cmake shenanigans for gamemode

todo: cmake shenanigans for gamemode
DraVee force-pushed liz-gamemode-flatten from 044e24fd21
Some checks failed
eden-license / license-header (pull_request) Successful in 42s
Details
GitHub Actions [CI] Build failed
Details
to f97f26d22b
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-12-05 02:20:20 +01:00 Compare
DraVee approved these changes 2025-12-07 07:08:46 +01:00
DraVee merged commit 83332316aa into master 2025-12-07 07:13:44 +01:00
DraVee deleted branch liz-gamemode-flatten 2025-12-07 07:13:51 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Shinmegumi
crueter
CamilleLaVey
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!353
No description provided.