eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[ports] build fixes for *BSD make #3496

Merged
crueter merged 2 commits from lizzie/gmake-fix into master 2026-03-08 19:32:25 +01:00
Conversation 5 Commits 2 Files changed 3 +17 -3
Lizzie commented 2026-02-08 01:48:25 +01:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
DraVee commented 2026-02-10 02:27:32 +01:00
Member
Copy link

CC: @crueter

CC: @crueter
DraVee approved these changes 2026-02-10 02:27:47 +01:00
crueter requested changes 2026-02-14 07:25:25 +01:00
Dismissed
src/qt_common/CMakeLists.txt Outdated
@ -90,1 +90,3 @@
if (DEFINED Qt6Gui_PRIVATE_INCLUDE_DIRS)
if (PLATFORM_NETBSD)
# QtGui6 has improper pkg-config configuration under NetBSD
target_include_directories(qt_common PRIVATE "${CMAKE_SYSROOT}/usr/pkg/qt6/include/QtGui/6.10.1/QtGui")
crueter commented 2026-02-14 07:25:02 +01:00
Owner
Copy link

Yeah we should not use hacks like this anymore. Hard coded versions are a massive red flag.

Yeah we should not use hacks like this anymore. Hard coded versions are a massive red flag.
Lizzie commented 2026-02-14 08:14:03 +01:00
Author
Member
Copy link

how should we approach this then?

how should we approach this then?
crueter commented 2026-02-22 19:27:58 +01:00
Owner
Copy link

Fix it upstream. We shouldn't cater to broken systems.

Fix it upstream. We shouldn't cater to broken systems.
DraVee commented 2026-03-06 15:57:59 +01:00
Member
Copy link

Any update on this?

Any update on this?
Lizzie force-pushed lizzie/gmake-fix from cf0cc6117e
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to e3e9245884
All checks were successful
eden-license / license-header (pull_request) Successful in 25s
Details
2026-03-08 19:30:57 +01:00 Compare
crueter approved these changes 2026-03-08 19:32:21 +01:00
crueter merged commit f2c46eadc1 into master 2026-03-08 19:32:25 +01:00
crueter deleted branch lizzie/gmake-fix 2026-03-08 19:32:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
DraVee
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3496
No description provided.