eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[fs] remove usage of subpar PooledBuffer #342

Merged
Shinmegumi merged 1 commit from liz-remove-fs-poolbuffer into master 2025-09-20 17:44:00 +02:00
Conversation 2 Commits 1 Files changed 9 +54 -271
Lizzie commented 2025-08-28 07:05:47 +02:00
Member
Copy link

PoolBuffer is a subpar "reimplementation" of an equivalent std::vector

Signed-off-by: lizzie lizzie@eden-emu.dev

PoolBuffer is a subpar "reimplementation" of an equivalent std::vector<char> Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-08-28 07:05:48 +02:00
[fs] remove usage of subpar PooledBuffer
Some checks failed
eden-license / license-header (pull_request) Failing after 21s
Details
a9c448b6ca 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-08-28 07:08:37 +02:00
Fix license headers
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
5f410d8ae7
Lizzie force-pushed liz-remove-fs-poolbuffer from 5f410d8ae7 to bbac668dc2 2025-08-29 00:22:09 +02:00 Compare
Lizzie force-pushed liz-remove-fs-poolbuffer from bbac668dc2 to d0c4908c01 2025-08-30 00:49:30 +02:00 Compare
Lizzie force-pushed liz-remove-fs-poolbuffer from d0c4908c01 to d089fbca96 2025-08-30 07:59:35 +02:00 Compare
Lizzie force-pushed liz-remove-fs-poolbuffer from d089fbca96 to 3e13f16a17 2025-08-30 10:15:31 +02:00 Compare
Lizzie force-pushed liz-remove-fs-poolbuffer from 3e13f16a17 to b620aae1c0 2025-09-03 18:56:28 +02:00 Compare
Shinmegumi force-pushed liz-remove-fs-poolbuffer from b620aae1c0 to 0fcbd2e513 2025-09-04 18:26:22 +02:00 Compare
Lizzie force-pushed liz-remove-fs-poolbuffer from 0fcbd2e513 to 437051c197 2025-09-13 22:34:34 +02:00 Compare
crueter force-pushed liz-remove-fs-poolbuffer from 437051c197 to d3c06c72f7 2025-09-17 03:54:03 +02:00 Compare
crueter approved these changes 2025-09-17 03:55:28 +02:00
Dismissed
Shinmegumi approved these changes 2025-09-20 17:31:35 +02:00
Dismissed
Lizzie force-pushed liz-remove-fs-poolbuffer from d3c06c72f7 to 084c51170b 2025-09-20 17:34:29 +02:00 Compare
Lizzie dismissed crueter's review 2025-09-20 17:34:30 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie dismissed Shinmegumi's review 2025-09-20 17:34:30 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Shinmegumi merged commit 87d42cf542 into master 2025-09-20 17:44:00 +02:00
Shinmegumi deleted branch liz-remove-fs-poolbuffer 2025-09-20 17:44:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#342
No description provided.
Delete branch "liz-remove-fs-poolbuffer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?