[VK]: Rework frame interpolation toggle & implement support for PC #340

Open

Gamer64 wants to merge 4 commits from frame-interp-rework into master

Gamer64 commented

2025-08-28 04:25:51 +02:00

Member

Rework & rebase of #217.

This stops using the toggle from JNI (that was veeeery messy) and just uses it from settings.h, making things more clear, including a nuke of the actually disabled frameskip.

if (frame_skipping)
frame_skip_threshold = (target_fps == 30) ? 2 : 2;

if (frame_counter % frame_skip_threshold != 0)
if (frame_interpolation && previous_frame)

Here's a preview of the old logic. We had frame_skipping disabled, so it wasn't working as expected. Frame interpolation would only get initialized or work properly if frame_skipping was enabled, as frame_interpolation was dependent on frame_skip_threshold, which was only being initialized if frame_skipping was enabled. This meant frame interpolation never worked properly (if it even did with the messy JNI implementation). Now with these changes, we've removed the old problematic and useless code of frameskip and brought support to PC, making this feature available beyond just Android.

Rework & rebase of https://git.eden-emu.dev/eden-emu/eden/pulls/217. This stops using the toggle from JNI (that was veeeery messy) and just uses it from settings.h, making things more clear, including a nuke of the actually disabled frameskip. if (frame_skipping) frame_skip_threshold = (target_fps == 30) ? 2 : 2; if (frame_counter % frame_skip_threshold != 0) if (frame_interpolation && previous_frame) Here's a preview of the old logic. We had frame_skipping disabled, so it wasn't working as expected. Frame interpolation would only get initialized or work properly if frame_skipping was enabled, as frame_interpolation was dependent on frame_skip_threshold, which was only being initialized if frame_skipping was enabled. This meant frame interpolation never worked properly (if it even did with the messy JNI implementation). Now with these changes, we've removed the old problematic and useless code of frameskip and brought support to PC, making this feature available beyond just Android.

CamilleLaVey force-pushed frame-interp-rework from 563c3bb289

eden-license / license-header (pull_request) Successful in 23s

Details

to 3fafbaa00e

eden-license / license-header (pull_request) Successful in 23s

Details

2025-08-29 03:22:57 +02:00

Compare