[vk] Remove UniformRing and vkCmdResetQueryPool #3270

Merged

CamilleLaVey merged 1 commit from xcde/1-of-2 into master 2026-01-07 06:52:18 +01:00

Conversation 3 Commits 1 Files changed 6 +10 -106

DraVee commented 2026-01-05 01:58:58 +01:00

Member

Copy link

Fixes perfomance regression on Xenoblade Chronicles DE and Pokemon Scarlet (among other games)
It should be investigated the reason why such perfomance loss (more than ~10% in some case)

At core it partially reverted the following commits:

Reverts "[vk] Introduce Ring Buffers for Uniform Buffer (#2698)"
This reverts commit 776958c79d.

Revert "[vk] Bring Vulkan closer to Spec (#180)"
This reverts commit c8d6f23129.

Revert "[VK] PR 180 extension (#257)"
This reverts commit 444b9f361e.

Revert "[vk] Fixes regression of PR #180 vk_scheduler.cpp for AMD GPU and Windows OS (#3071)"
This reverts commit be218cc020.

Signed-off-by: Caio Oliveira caiooliveirafarias0@gmail.com

Fixes perfomance regression on Xenoblade Chronicles DE and Pokemon Scarlet (among other games) It should be investigated the reason why such perfomance loss (more than ~10% in some case) At core it partially reverted the following commits: Reverts "[vk] Introduce Ring Buffers for Uniform Buffer (#2698)" This reverts commit 776958c79d. Revert "[vk] Bring Vulkan closer to Spec (#180)" This reverts commit c8d6f23129. Revert "[VK] PR 180 extension (#257)" This reverts commit 444b9f361e. Revert "[vk] Fixes regression of PR #180 vk_scheduler.cpp for AMD GPU and Windows OS (#3071)" This reverts commit be218cc020. Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>

DraVee changed title from WIP: xcde/1-of-2 to [vk] Revert commits that introduced perfomance regression 2026-01-06 02:49:04 +01:00

DraVee requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr, Lizzie 2026-01-06 02:49:04 +01:00

DraVee force-pushed xcde/1-of-2 from c57139ff69 to 168523ff5b 2026-01-06 03:24:46 +01:00 Compare

DraVee force-pushed xcde/1-of-2 from 168523ff5b to 3c421221e9 2026-01-06 04:07:54 +01:00 Compare

DraVee force-pushed xcde/1-of-2 from 3c421221e9 to 6bef7dadc2 2026-01-06 04:57:54 +01:00 Compare

DraVee force-pushed xcde/1-of-2 from 9057bebaf0 to d1a7036c01 2026-01-07 00:23:32 +01:00 Compare

Maufeat force-pushed xcde/1-of-2 from d1a7036c01 to e8f793aa6d 2026-01-07 01:43:17 +01:00 Compare

DraVee force-pushed xcde/1-of-2 from 8e79f337c2 to d1a7036c01 2026-01-07 04:42:08 +01:00 Compare

DraVee force-pushed xcde/1-of-2 from d1a7036c01 to e0d229a0b6 2026-01-07 06:07:00 +01:00 Compare

DraVee changed title from [vk] Revert commits that introduced perfomance regression to [vk] Remove UniformRing and vkCmdResetQueryPool 2026-01-07 06:07:20 +01:00

Lizzie approved these changes 2026-01-07 06:45:23 +01:00

Dismissed

Lizzie referenced this pull request 2026-01-07 06:46:25 +01:00

WIP: future PR testing 1 #3278

Lizzie approved these changes 2026-01-07 06:51:40 +01:00

CamilleLaVey approved these changes 2026-01-07 06:51:56 +01:00

CamilleLaVey merged commit 8440c2074d into master 2026-01-07 06:52:18 +01:00

CamilleLaVey deleted branch xcde/1-of-2 2026-01-07 06:52:18 +01:00

CamilleLaVey referenced this pull request from a commit 2026-01-07 06:52:21 +01:00

[vk] Remove UniformRing and vkCmdResetQueryPool (#3270)

Sign in to join this conversation.

Reviewers

No reviewers

Maufeat

crueter

MrPurple666

MaranBr

Lizzie

CamilleLaVey

Labels

Clear labels   

android

Specific to android platform

  

audio

  

bug

Something is not working

  

ci

For changes to the ci/building

  

cmake

  

confirmed

Used when testers confirm a bug is reported and it is reproducable.

  

core

For core changes to the emulator

  

desktop

Specific to desktop PCs, handhelds, etc.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Frontend changes

  

fw

Changes related to firmware

  

git

For enhancements or changes regarding git.

  

graphics

  

loader

For changes to any of the loader implementations

  

nv gpu

For use with changes that involve the emulator GPU and any services.

  

ui

  

vulkan

Used on anything Vulkan-related

No labels

android

audio

bug

ci

cmake

confirmed

core

desktop

duplicate

enhancement

frontend

fw

git

graphics

loader

nv gpu

ui

vulkan

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

eden-emu/eden!3270

No description provided.