eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

WIP: [cheat] add dmnt, indiviual cheats, etc. #3178

Draft
Maufeat wants to merge 6 commits from dmnt2 into master
pull from: dmnt2
merge into: eden-emu:master
Conversation 7 Commits 6 Files changed 29 +2199 -952
Maufeat commented 2025-12-18 14:12:08 +01:00
Member
Copy link

Add's dmnt:cht service for cheats, needs more refinement later on and probably a separate cheat window for handling cheats on runtime.
Also can handle now multiple cheats in one file.

Tested on Android and Windows.

Credits to @crueter for initial the implementation

Current TODO:

  • per-cheat enable/disable [android/desktop]
  • Prevent each cheat being deleted
  • Get cheat name from first line if incompatible (cheat files should match build_id)
  • Read cheats from SDMC
  • Fix: SDMC cheats properly disable on add-on
  • Add runtime enable/disable
  • Don't show cheats with "parent_name" on main menu
  • Fix: crash when running a game (with cheats on) a second time (liz: its referencing a cheat process that doesnt exist)
  • Fix: cheats that don't use first line as name of patch
  • Fix: incompatible cheats showing the name of the cheat (cheat is not properly using the first [] as name of patch), fallback to build_id
Add's dmnt:cht service for cheats, needs more refinement later on and probably a separate cheat window for handling cheats on runtime. Also can handle now multiple cheats in one file. Tested on Android and Windows. Credits to @crueter for initial the implementation Current TODO: - [x] per-cheat enable/disable [android/desktop] - [x] Prevent each cheat being deleted - [x] Get cheat name from first line if incompatible (cheat files should match build_id) - [x] Read cheats from SDMC - [ ] Fix: SDMC cheats properly disable on add-on - [ ] Add runtime enable/disable - [ ] Don't show cheats with "parent_name" on main menu - [ ] Fix: crash when running a game (with cheats on) a second time (liz: its referencing a cheat process that doesnt exist) - [ ] Fix: cheats that don't use first line as name of patch - [ ] Fix: incompatible cheats showing the name of the cheat (cheat is not properly using the first [] as name of patch), fallback to build_id
Maufeat force-pushed dmnt2 from 397a1f4022
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to eb52e55f78
Some checks failed
eden-license / license-header (pull_request) Failing after 39s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2026-01-21 06:25:33 +01:00 Compare
DraVee force-pushed dmnt2 from 8875d3f998
Some checks failed
eden-license / license-header (pull_request) Failing after 41s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 7308c2c6a3
Some checks are pending
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Successful in 10m47s
Details
2026-02-02 19:04:57 +01:00 Compare
DraVee force-pushed dmnt2 from 7308c2c6a3
Some checks are pending
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Successful in 10m47s
Details
to 396701b426
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
2026-02-05 05:07:28 +01:00 Compare
crueter commented 2026-03-08 22:57:49 +01:00
Owner
Copy link

this should be good once it's rebased. though, it will need some additional work to integrate with my add-on list changes

this should be good once it's rebased. though, it will need some additional work to integrate with my add-on list changes
DraVee force-pushed dmnt2 from 396701b426
All checks were successful
eden-license / license-header (pull_request) Successful in 21s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to 527e0a618e
Some checks reported errors
eden-license / license-header (pull_request) Successful in 24s
Details
GitHub Actions [CI] Build cancelled
Details
2026-03-09 03:39:58 +01:00 Compare
DraVee force-pushed dmnt2 from 527e0a618e
Some checks reported errors
eden-license / license-header (pull_request) Successful in 24s
Details
GitHub Actions [CI] Build cancelled
Details
to 1457123bcc
Some checks failed
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build failed
Details
2026-03-09 03:45:36 +01:00 Compare
DraVee requested changes 2026-03-09 03:46:51 +01:00
src/core/hle/service/dmnt/cheat_virtual_machine.cpp Outdated
@ -0,0 +76,4 @@
manager.CommandLog(
fmt::format("Math Type: {:X}", static_cast<u32>(perform_math_static->math_type)));
manager.CommandLog(fmt::format("Value: {:X}", perform_math_static->value));
} else if (auto begin_keypress_cond =
DraVee commented 2026-03-09 03:46:49 +01:00
Member
Copy link

Oh god, need to fix indentation

Oh god, need to fix indentation
DraVee marked this conversation as resolved
DraVee force-pushed dmnt2 from 1457123bcc
Some checks failed
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build failed
Details
to 167f4f40ad
Some checks reported errors
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build cancelled
Details
2026-03-10 15:09:53 +01:00 Compare
DraVee force-pushed dmnt2 from 167f4f40ad
Some checks reported errors
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build cancelled
Details
to 1c57cb5603
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
2026-03-10 15:26:56 +01:00 Compare
Update src/common/android/id_cache.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
311420a49e 
dont go kaboon plz dont

Signed-off-by: xbzk <xbzk@eden-emu.dev>
DraVee force-pushed dmnt2 from 311420a49e
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
to b6f4cc1873
Some checks reported errors
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build cancelled
Details
2026-03-11 17:25:40 +01:00 Compare
DraVee force-pushed dmnt2 from b6f4cc1873
Some checks reported errors
eden-license / license-header (pull_request) Successful in 25s
Details
GitHub Actions [CI] Build cancelled
Details
to c2e4484172
Some checks reported errors
eden-license / license-header (pull_request) Successful in 33s
Details
GitHub Actions [CI] Build cancelled
Details
2026-03-11 17:26:39 +01:00 Compare
[fixup] fix problem introduced on fix merge conflicts
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
69c29c651e
 
Signed-off-by: xbzk <xbzk@eden-emu.dev>
DraVee commented 2026-03-11 18:02:48 +01:00
Member
Copy link

@DraVee wrote in #3178 (comment):

Cheats are being detected as mods

image

Need to change message from Mods to Add-ons

@DraVee wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3178#issuecomment-22548: > Cheats are being detected as mods > > [![image](/attachments/c34f747a-258e-4739-ae7f-98a1b15c59bc)](/eden-emu/eden/attachments/c34f747a-258e-4739-ae7f-98a1b15c59bc) Need to change message from Mods to Add-ons
crueter commented 2026-03-11 21:01:09 +01:00
Owner
Copy link

@DraVee wrote in #3178 (comment):

Need to change message from Mods to Add-ons

The add-on manager only supports deleting mods.

@DraVee wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3178#issuecomment-22596: > Need to change message from Mods to Add-ons The add-on manager **only** supports deleting mods.
[dmnt] Fix CheatCompatibility
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Release published
Details
80e2a7382b
 
* now it follows Atmosphere system to only enable cheat if cheat_name.txt = build_id
* also deduplicate active update

Signed-off-by: DraVee <chimera@dravee.dev>
DraVee commented 2026-03-11 22:32:24 +01:00
Member
Copy link

@crueter wrote in #3178 (comment):

@DraVee wrote in #3178 (comentário):

Need to change message from Mods to Add-ons

The add-on manager only supports deleting mods.

Well a cheat is mod, so its ok then

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/3178#issuecomment-22598: > @DraVee wrote in #3178 (comentário): > > > Need to change message from Mods to Add-ons > > The add-on manager **only** supports deleting mods. Well a cheat is mod, so its ok then
[file_sys] Check for Mods the same way on SDMC and non-SDMC
Some checks reported errors
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build cancelled
Details
3092d2274f
 
* fix getting cheats from SDMC (allow usage with aio-switch-updater)
DraVee reviewed 2026-03-12 03:24:42 +01:00
src/core/file_sys/patch_manager.cpp Outdated
@ -947,1 +947,4 @@
AppendCommaIfNotEmpty(types, "Cheats");
}
if (has_cheats && is_sdmc)
mod_name = "Atmosphère Cheats";
DraVee commented 2026-03-12 03:24:42 +01:00
Member
Copy link

Can this lead to problem in the future?

Can this lead to problem in the future?
DraVee marked this conversation as resolved
...
Some checks failed
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build failed
Details
7fc2b0f93d
DraVee changed title from [cheat] add dmnt, indiviual cheats, etc. to WIP: [cheat] add dmnt, indiviual cheats, etc. 2026-03-12 04:03:25 +01:00
DraVee commented 2026-03-12 04:20:20 +01:00
Member
Copy link
                // Note: This function *MUST* be called only with the cheat lock held.
                bool has_cheat_process =
                    cheat_process_debug_handle != InvalidHandle
                    && system.ApplicationProcess()
                    && system.ApplicationProcess()->GetProcessId() == cheat_process_metadata.process_id;
            
                if (!has_cheat_process) {
                    CloseActiveCheatProcess();
                }
            
                return has_cheat_process;
            }```
```bool CheatProcessManager::HasActiveCheatProcess() { // Note: This function *MUST* be called only with the cheat lock held. bool has_cheat_process = cheat_process_debug_handle != InvalidHandle && system.ApplicationProcess() && system.ApplicationProcess()->GetProcessId() == cheat_process_metadata.process_id; if (!has_cheat_process) { CloseActiveCheatProcess(); } return has_cheat_process; }```
Some checks failed
eden-license / license-header (pull_request) Successful in 27s
Required
Details
GitHub Actions [CI] Build failed
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dmnt2:dmnt2
git switch dmnt2
Sign in to join this conversation.
Reviewers
No reviewers
MaranBr
Lizzie
crueter
CamilleLaVey
MrPurple666
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3178
No description provided.