eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

[gpu/NVDRV] Unstub SetErrorNotifier and add PostErrorNotification #312

Closed
SDK-Chan wants to merge 3 commits from unstub-error-notifier into master
pull from: unstub-error-notifier
merge into: eden-emu:master
Conversation 1 Commits 3 Files changed 2 +95 -4
SDK-Chan commented 2025-08-25 16:52:41 +02:00
Member
Copy link

Add functionality to SetErrorNotifier.
Functionality should now be correctly written to memory.

Add PostErrorNotification.
This ensures that some functions with bad return values now properly set a error status.

Created a NotifierStatus enum to make error categories more descriptive.

Credits to JPikachu for creating the initial stub, and showing me how I should proceed to make that function complete.

Add functionality to SetErrorNotifier. Functionality should now be correctly written to memory. Add PostErrorNotification. This ensures that some functions with bad return values now properly set a error status. Created a NotifierStatus enum to make error categories more descriptive. Credits to JPikachu for creating the initial stub, and showing me how I should proceed to make that function complete.
JPikachu commented 2025-08-25 17:19:49 +02:00
Member
Copy link

Looks good to me!
Well done @SDK-Chan

Looks good to me! Well done @SDK-Chan
CamilleLaVey force-pushed unstub-error-notifier from 02c98ec5e2
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to 69bc01f47d
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-08-29 00:13:49 +02:00 Compare
Shinmegumi closed this pull request 2025-09-17 19:24:04 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!312
No description provided.