eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

[vk] Fixes regression of PR #180 vk_scheduler.cpp for AMD GPU and Windows OS #3071

Merged
crueter merged 4 commits from :FFTactics-amd-windows-fix-experimental into master 2025-11-22 21:06:33 +01:00
Conversation 6 Commits 4 Files changed 1 +11 -6
John commented 2025-11-22 03:57:02 +01:00
Member
Copy link

Fixes AMD + Windows because it forces barriers to include the fragment test and color output stages explicitly, ensuring that all render pass writes are visible before later commands. Without it, AMD’s driver sometimes skipped synchronization, causing broken rendering in Final Fantasy Tactics.

PR #3069 also fixes this regression by reverting vk_scheduler.cpp in PR #180.
This PR fixes PR #180 and may be the better solution.

Fixes AMD + Windows because it forces barriers to include the fragment test and color output stages explicitly, ensuring that all render pass writes are visible before later commands. Without it, AMD’s driver sometimes skipped synchronization, causing broken rendering in Final Fantasy Tactics. PR #3069 also fixes this regression by reverting vk_scheduler.cpp in PR #180. This PR fixes PR #180 and may be the better solution.
John changed title from Experimental: Attempt to fix PR#180 without fully reverting vk_scheduler.cpp to old logic. to Experimental: Attempt to fix PR #180 without fully reverting vk_scheduler.cpp to old logic. 2025-11-22 03:57:34 +01:00
John force-pushed FFTactics-amd-windows-fix-experimental from e4271a072b
All checks were successful
eden-license / license-header (pull_request) Successful in 44s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to b91547c05d
All checks were successful
eden-license / license-header (pull_request) Successful in 43s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-22 04:12:37 +01:00 Compare
Closer to spec, avoids over‑sync
All checks were successful
eden-license / license-header (pull_request) Successful in 43s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
6d0259aed5 
Experiment: Includes only the stages actually used in the render pass.
John commented 2025-11-22 15:06:46 +01:00
Author
Member
Copy link

6d0259aed5 Broke the graphics again so going back to previous logic.

6d0259aed5 Broke the graphics again so going back to previous logic.
Update src/video_core/renderer_vulkan/vk_scheduler.cpp
Some checks failed
eden-license / license-header (pull_request) Successful in 44s
Details
GitHub Actions [CI] Build failed
Details
bbafd6d697 
Reverting to previous logic that worked.
It is fixes to PR #180 vk_scheduler.cpp to better support AMD+Windows instead of reverting the logic. This fixes Final Fantasy Tactics broken graphics.

b91547c05d was confirmed to fix the broken graphics with AMD+Windows.
John commented 2025-11-22 15:25:19 +01:00
Author
Member
Copy link

b91547c05d or e4271a072b logic fixed it.

b91547c05d or e4271a072b logic fixed it.
image.png
1.8 MiB
image2.png
2.6 MiB
image.png image2.png
Update src/video_core/renderer_vulkan/vk_scheduler.cpp
All checks were successful
eden-license / license-header (pull_request) Successful in 44s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
871f34588e
John changed title from Experimental: Attempt to fix PR #180 without fully reverting vk_scheduler.cpp to old logic. to [vk] Fixes regression of PR #180 vk_schedulet.cpp for AMD GPU and Windows OS 2025-11-22 17:10:11 +01:00
John changed title from [vk] Fixes regression of PR #180 vk_schedulet.cpp for AMD GPU and Windows OS to [vk] Fixes regression of PR #180 vk_scheduler.cpp for AMD GPU and Windows OS 2025-11-22 17:34:25 +01:00
John commented 2025-11-22 17:37:15 +01:00
Author
Member
Copy link

871f34588e is just a cleaned up and made more readable of b91547c05d logic or e4271a072b logic

871f34588e is just a cleaned up and made more readable of b91547c05d logic or e4271a072b logic
John commented 2025-11-22 17:49:41 +01:00
Author
Member
Copy link

Latest changes in 871f34588e confirmed to fix Final Fantasy Tactics for AMD+Windows!

Latest changes in 871f34588e confirmed to fix Final Fantasy Tactics for AMD+Windows!
image.png
16 KiB
image2.png
1.3 MiB
image3.png
2.3 MiB
image.png image2.png image3.png
crueter approved these changes 2025-11-22 20:52:28 +01:00
Lizzie approved these changes 2025-11-22 21:05:47 +01:00
crueter merged commit be218cc020 into master 2025-11-22 21:06:33 +01:00
crueter deleted branch FFTactics-amd-windows-fix-experimental 2025-11-22 21:06:40 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
MaranBr
CamilleLaVey
Maufeat
crueter
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!3071
No description provided.