eden-emu/eden
24
3
Fork 18
Code Issues 90 Pull requests 75 Projects 1 Releases 7 Wiki Activity Actions

[tools] MSVC environment loader, POSIX vulkan/MSVC install scripts #2993

Merged
MaranBr merged 25 commits from DraVee/eden:docs/update-win into master 2025-11-15 17:53:14 +01:00
Conversation 6 Commits 25 Files changed 9 +595 -29
DraVee commented 2025-11-10 00:40:40 +01:00
Member
Copy link
  • also move install-vulkan-sdk.ps1 to tools
* also move install-vulkan-sdk.ps1 to tools
DraVee changed title from WIP: Add "Convenience tool for loading MSVC envirroment" to WIP: [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-10 00:40:55 +01:00
DraVee changed title from WIP: [chore] Add "Convenience tool for loading MSVC envirroment" to [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-11 00:36:38 +01:00
DraVee changed title from [chore] Add "Convenience tool for loading MSVC envirroment" to WIP: [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-11 03:26:24 +01:00
DraVee changed title from WIP: [chore] Add "Convenience tool for loading MSVC envirroment" to [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-12 05:34:42 +01:00
crueter commented 2025-11-12 05:38:01 +01:00
Owner
Copy link

While we're at it, might as well provide Git Bash versions

https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L132
https://github.com/crueter-ci/FFmpeg/blob/master/tools/build.sh#L24

vulkan

: "${VULKAN_VER:=1.4.328.1}"
: "${VULKAN_ROOT:=C:/VulkanSDK/"$VULKAN_VER"}"
VULKAN_ROOT_UNIX=$(cygpath -u "$VULKAN_ROOT")

if [ -d "$VULKAN_ROOT_UNIX" ]; then
	echo "-- Vulkan SDK already installed"
	return
fi

echo "-- Installing Vulkan SDK..."
[ ! -f vulkan.exe ] && curl -L https://sdk.lunarg.com/sdk/download/$VULKAN_VER/windows/vulkan-sdk-windowxX64-$VULKAN_VER.exe -o vulkan.exe
./vulkan.exe --root "$VULKAN_ROOT" --accept-licenses --default-answer --confirm-command install

msvc, alternative(?)

# shellcheck disable=SC2154
CLPATH=$(cygpath -u "$VCToolsInstallDir\\bin\\Host${VSCMD_ARG_HOST_ARCH}\\${VSCMD_ARG_TGT_ARCH}")
export PATH="$CLPATH:$PATH"
While we're at it, might as well provide Git Bash versions https://git.crueter.xyz/scripts/windev/src/branch/master/install.sh#L132 https://github.com/crueter-ci/FFmpeg/blob/master/tools/build.sh#L24 vulkan ```sh : "${VULKAN_VER:=1.4.328.1}" : "${VULKAN_ROOT:=C:/VulkanSDK/"$VULKAN_VER"}" VULKAN_ROOT_UNIX=$(cygpath -u "$VULKAN_ROOT") if [ -d "$VULKAN_ROOT_UNIX" ]; then echo "-- Vulkan SDK already installed" return fi echo "-- Installing Vulkan SDK..." [ ! -f vulkan.exe ] && curl -L https://sdk.lunarg.com/sdk/download/$VULKAN_VER/windows/vulkan-sdk-windowxX64-$VULKAN_VER.exe -o vulkan.exe ./vulkan.exe --root "$VULKAN_ROOT" --accept-licenses --default-answer --confirm-command install ``` msvc, alternative(?) ```sh # shellcheck disable=SC2154 CLPATH=$(cygpath -u "$VCToolsInstallDir\\bin\\Host${VSCMD_ARG_HOST_ARCH}\\${VSCMD_ARG_TGT_ARCH}") export PATH="$CLPATH:$PATH" ```
DraVee changed title from [chore] Add "Convenience tool for loading MSVC envirroment" to WIP: [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-12 06:16:57 +01:00
DraVee force-pushed docs/update-win from afeeb5d02b
Some checks failed
eden-license / license-header (pull_request) Successful in 9m56s
Details
GitHub Actions [CI] Build failed
Details
to 7ac3f77b90
Some checks failed
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build failed
Details
2025-11-15 01:46:48 +01:00 Compare
DraVee force-pushed docs/update-win from 7ac3f77b90
Some checks failed
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build failed
Details
to 065b133b4b
Some checks reported errors
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build cancelled
Details
2025-11-15 03:24:24 +01:00 Compare
DraVee force-pushed docs/update-win from 157bfcf6d5
All checks were successful
eden-license / license-header (pull_request) Successful in 39s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 6f60b0540e
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-15 04:35:01 +01:00 Compare
DraVee reviewed 2025-11-15 04:38:51 +01:00
tools/windows/load-msvc-env.sh Outdated
@ -0,0 +2,4 @@
# SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
# SPDX-License-Identifier: GPL-3.0-or-later
VCVARS_BASH_URL="https://github.com/Vee99BR/vcvars-bash/raw/refs/heads/main/vcvarsall.sh"
DraVee commented 2025-11-15 04:38:50 +01:00
Author
Member
Copy link

@crueter should we put it in-tree or clone to Eden-CI?

@crueter should we put it in-tree or clone to Eden-CI?
crueter commented 2025-11-15 04:47:10 +01:00
Owner
Copy link

in-tree

in-tree
DraVee marked this conversation as resolved
DraVee changed title from WIP: [chore] Add "Convenience tool for loading MSVC envirroment" to [chore] Add "Convenience tool for loading MSVC envirroment" 2025-11-15 05:19:40 +01:00
crueter requested changes 2025-11-15 05:24:09 +01:00
Dismissed
docs/Deps.md Outdated
crueter commented 2025-11-15 05:23:40 +01:00
Owner
Copy link

We can add KDevelop here

We can add KDevelop here
DraVee marked this conversation as resolved
tools/windows/install-vulkan-sdk.sh Outdated
@ -0,0 +25,4 @@
chmod +x "$DESTINATION"
echo "Finished downloading $EXE_FILE"
echo "Installing Vulkan SDK $VULKAN_SDK_VER..."
crueter commented 2025-11-15 05:21:11 +01:00
Owner
Copy link

butwhy

butwhy
DraVee commented 2025-11-15 05:27:01 +01:00
Author
Member
Copy link

You need admin permissions to install Vulkan SDK, we can call PowerShell (another solution is just show an error)

You need admin permissions to install Vulkan SDK, we can call PowerShell (another solution is just show an error)
crueter commented 2025-11-15 05:28:26 +01:00
Owner
Copy link

This has always worked for me without admin on Git Bash

This has always worked for me without admin on Git Bash
DraVee commented 2025-11-15 05:32:11 +01:00
Author
Member
Copy link

It fails cause we're writing to C:/ and don't show the real reason why it fails (just failed mkdir)

It fails cause we're writing to `C:/` and don't show the real reason why it fails (just failed mkdir)
crueter commented 2025-11-15 05:34:39 +01:00
Owner
Copy link

uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh try /c/VulkanSDK ????????????

uhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh try `/c/VulkanSDK` ????????????
crueter marked this conversation as resolved
tools/windows/install-vulkan-sdk.sh Outdated
@ -0,0 +28,4 @@
echo "Installing Vulkan SDK $VULKAN_SDK_VER..."
"$DESTINATION" --root "$VULKAN_ROOT_UNIX" --accept-licenses --default-answer --confirm-command install
echo "Finished installing Vulkan SDK $VULKAN_SDK_VER"
crueter commented 2025-11-12 06:17:26 +01:00
Owner
Copy link

echo "-- message..."

`echo "-- message..."`
DraVee marked this conversation as resolved
tools/windows/load-msvc-env.sh Outdated
@ -0,0 +4,4 @@
# shellcheck disable=SC2154
CLPATH=$(cygpath -u "$VCToolsInstallDir\\bin\\Host${VSCMD_ARG_HOST_ARCH}\\${VSCMD_ARG_TGT_ARCH}")
export PATH="$CLPATH:$PATH"
crueter commented 2025-11-12 06:17:54 +01:00
Owner
Copy link

For this I kinda lied because you still need vswhere. This script specifically is getting cl.exe and link.exe into msys2

For this I kinda lied because you still need vswhere. This script specifically is getting cl.exe and link.exe into msys2
DraVee marked this conversation as resolved
crueter requested changes 2025-11-15 05:27:49 +01:00
Dismissed
crueter left a comment
Owner
Copy link

ignore the other one, it got mangled

ignore the other one, it got mangled
docs/Build.md Outdated
@ -59,2 +62,4 @@
> - `tools/windows/load-msvc-env.ps1`
Availables `<GENERATOR>`:
- MSYS2: `MSYS Makefiles`
crueter commented 2025-11-15 05:25:33 +01:00
Owner
Copy link

Available*

Available*
DraVee marked this conversation as resolved
docs/Build.md Outdated
@ -64,2 +69,3 @@
BUILD_TYPE should usually be `Release` or `RelWithDebInfo` (debug symbols--compiled executable will be large). If you are using a debugger and annoyed with stuff getting optimized out, try `Debug`.
Availables `<BUILD_TYPE>`:
- `Release` (default)
crueter commented 2025-11-15 05:25:39 +01:00
Owner
Copy link

Available*

Available*
DraVee marked this conversation as resolved
docs/Build.md Outdated
@ -143,3 +150,4 @@
If you are using the `UNIX Makefiles` or `Visual Studio 17 2022` as `<GENERATOR>`, you must also want to add `--parallel $(nproc)` to this command to improve building time.
```
cmake --build build
crueter commented 2025-11-15 05:26:03 +01:00
Owner
Copy link
you should also add `--parallel` for faster build times
``` you should also add `--parallel` for faster build times ```
DraVee marked this conversation as resolved
docs/Deps.md Outdated
@ -22,3 +25,3 @@
* On Linux, *BSD and macOS, this can be done by the package manager
- If you wish to use Qt Creator, append `qtcreator` or `qt-creator` to the commands seen below.
* MSVC/clang-cl users on Windows must install through the [official installer](https://www.qt.io/download-qt-installer-oss)
* MSVC/clang-cl users on Windows must install through the official [Qt 6](https://www.qt.io/download-qt-installer-oss) installer
crueter commented 2025-11-15 05:26:24 +01:00
Owner
Copy link

kdevelop can be added here probably

kdevelop can be added here probably
DraVee commented 2025-11-15 05:30:54 +01:00
Author
Member
Copy link

Could be add in another occasion (I dont even use IDE)

Could be add in another occasion (I dont even use IDE)
DraVee marked this conversation as resolved
docs/Deps.md Outdated
@ -25,3 +27,4 @@
* MSVC/clang-cl users on Windows must install through the official [Qt 6](https://www.qt.io/download-qt-installer-oss) installer
* Linux and macOS users may choose to use the installer as well.
* MSYS2 can also install Qt 6 via the package manager
crueter commented 2025-11-15 05:26:39 +01:00
Owner
Copy link

leave it as it was because this'll be valid for every future Qt version

leave it as it was because this'll be valid for every future Qt version
👍 1
DraVee marked this conversation as resolved
tools/windows/install-vulkan-sdk.sh Outdated
@ -0,0 +25,4 @@
else
DESTINATION=$(cygpath -w "$PWD/$EXE_FILE")
powershell.exe -Command "
Start-Process \"$DESTINATION\" -Verb RunAs -ArgumentList @(
crueter commented 2025-11-15 05:26:52 +01:00
Owner
Copy link

butwhy

butwhy
DraVee marked this conversation as resolved
crueter force-pushed docs/update-win from eab03dd1cb
Some checks failed
eden-license / license-header (pull_request) Successful in 41s
Details
GitHub Actions [CI] Build failed
Details
to 42ed048be7
All checks were successful
eden-license / license-header (pull_request) Successful in 38s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-11-15 08:19:02 +01:00 Compare
crueter approved these changes 2025-11-15 08:48:51 +01:00
crueter changed title from [chore] Add "Convenience tool for loading MSVC envirroment" to [tools] MSVC environment loader, POSIX vulkan/MSVC install scripts 2025-11-15 09:06:00 +01:00
MaranBr approved these changes 2025-11-15 17:53:07 +01:00
MaranBr merged commit 7e730a121b into master 2025-11-15 17:53:14 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
Lizzie
crueter
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2993
No description provided.