eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

[service, ns, acc] Stub IsQualificationTransitionSupportedByProcessId and SaveDataThumbnail commands #299

Closed
JPikachu wants to merge 1 commit from borderlands-services into master
pull from: borderlands-services
merge into: eden-emu:master
Conversation 3 Commits 1 Files changed 7 +54 -8
JPikachu commented 2025-08-22 01:06:22 +02:00
Member
Copy link
  • ns: Stubbed IsQualificationTransitionSupportedByProcessId (2520) to always return true.
  • acc: added the missing SaveDataThumbnail commands:
    • ClearSaveDataThumbnail (111) → stubbed, returns success.
    • LoadSaveDataThumbnail (112) → stubbed, returns success with dummy thumbnail.
    • GetSaveDataThumbnailExistence (113) → stubbed, returns true.
- ns: Stubbed IsQualificationTransitionSupportedByProcessId (2520) to always return true. - acc: added the missing SaveDataThumbnail commands: * ClearSaveDataThumbnail (111) → stubbed, returns success. * LoadSaveDataThumbnail (112) → stubbed, returns success with dummy thumbnail. * GetSaveDataThumbnailExistence (113) → stubbed, returns true.
JPikachu force-pushed borderlands-services from be4d4458d8
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
to 07581a2161
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
2025-08-24 17:03:22 +02:00 Compare
JPikachu force-pushed borderlands-services from 07581a2161
All checks were successful
eden-license / license-header (pull_request) Successful in 24s
Details
to 3b18de150e
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Details
2025-08-25 00:01:30 +02:00 Compare
JPikachu commented 2025-08-25 01:14:18 +02:00
Author
Member
Copy link

removing "This allows titles like Borderlands GOTY to progress past save-related errors." as the save error will most likely need a different type of fix. It needs to be chosen wether or not we still want these new stubs though.

removing "This allows titles like Borderlands GOTY to progress past save-related errors." as the save error will most likely need a different type of fix. It needs to be chosen wether or not we still want these new stubs though.
Lizzie reviewed 2025-08-25 01:19:58 +02:00
src/core/hle/service/acc/acc.cpp
@ -1111,0 +1118,4 @@
void Module::Interface::LoadSaveDataThumbnail(HLERequestContext& ctx) {
// TODO: Grab thumbnail from Nand so this can be unstubbed
// For now, pretend a thumbnail exists and return dummy data
std::vector<u8> dummy_thumbnail(THUMBNAIL_SIZE, 0);
Lizzie commented 2025-08-25 01:19:58 +02:00
Member
Copy link

Use boost::static_vector, or std::array, maybe?

Use boost::static_vector, or std::array, maybe?
JPikachu commented 2025-08-25 17:37:31 +02:00
Author
Member
Copy link

Thank you @Lizzie for the suggestion, I will close this PR to clean it up a little in the branch and use this advice in my full (not stubbed) implementation.

Thank you @Lizzie for the suggestion, I will close this PR to clean it up a little in the branch and use this advice in my full (not stubbed) implementation.
JPikachu closed this pull request 2025-08-25 17:37:32 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 22s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!299
No description provided.