eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[ci] fix script not working on non-sh shells #296

Closed
Lizzie wants to merge 2 commits from fix-license-script-not-working-on-sh into master
pull from: fix-license-script-not-working-on-sh
merge into: eden-emu:master
Conversation 5 Commits 2 Files changed 1 +2 -6
Lizzie commented 2025-08-21 22:36:38 +02:00
Member
Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie added 1 commit 2025-08-21 22:36:38 +02:00
[ci] fix script not working on non-sh shells
All checks were successful
eden-license / license-header (pull_request) Successful in 1m27s
Details
bc2147ab21 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
crueter added 1 commit 2025-08-21 22:54:47 +02:00
[ci] use better license-header impl that is not as cursed
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
b9b18458fb 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter commented 2025-08-21 22:55:25 +02:00
Owner
Copy link

see if it works on sh now (did for me)

see if it works on sh now (did for me)
Lizzie commented 2025-08-21 23:04:54 +02:00
Author
Member
Copy link

@crueter wrote in #296 (comment):

see if it works on sh now (did for me)

not on freebsd

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/296#issuecomment-2161: > see if it works on sh now (did for me) not on freebsd
crueter commented 2025-08-22 00:57:30 +02:00
Owner
Copy link

@Lizzie wrote in #296 (comment):

@crueter wrote in #296 (comment):

see if it works on sh now (did for me)

not on freebsd

Post the error

@Lizzie wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/296#issuecomment-2165: > @crueter wrote in #296 (comment): > > > see if it works on sh now (did for me) > > not on freebsd Post the error
Lizzie force-pushed fix-license-script-not-working-on-sh from b9b18458fb to 152fe0ea26 2025-08-30 00:49:57 +02:00 Compare
Lizzie force-pushed fix-license-script-not-working-on-sh from 152fe0ea26 to 02ad1b83c3 2025-08-30 07:58:52 +02:00 Compare
Lizzie commented 2025-08-30 07:59:11 +02:00
Author
Member
Copy link

@crueter wrote in #296 (comment):

Post the error

Getting branch changes
.ci/license-header.sh: ${COMMITS[...}: Bad substitution

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/296#issuecomment-2177: > Post the error Getting branch changes .ci/license-header.sh: ${COMMITS[...}: Bad substitution
crueter commented 2025-08-31 08:32:33 +02:00
Owner
Copy link

@Lizzie

@crueter wrote in #296 (comment):

Post the error

Getting branch changes
.ci/license-header.sh: ${COMMITS[...}: Bad substitution

I removed that in my commit

@Lizzie >@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/296#issuecomment-2177: > >> Post the error > >Getting branch changes >.ci/license-header.sh: ${COMMITS[...}: Bad substitution I removed that in my commit
Lizzie closed this pull request 2025-09-22 17:48:41 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#296
No description provided.
Delete branch "fix-license-script-not-working-on-sh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?