eden-emu/eden
24
8
Fork 31
Code Issues 108 Pull requests 107 Projects 2 Releases 12 Wiki Activity Actions

WIP: [core/hle/kernel] fix potential datarace when re-scheduling threads at termination #2899

Closed
Lizzie wants to merge 2 commits from lock-term-1 into chore/NamespaceIndentation
pull from: lock-term-1
merge into: eden-emu:chore/NamespaceIndentation
Conversation 4 Commits 2 Files changed 1 +1096 -1091
Lizzie commented 2025-10-30 20:55:40 +01:00
Member
Copy link

Fixes potential race where thread may be told to be non-running but inbetween the acquisition of the lock there may be another holder whom puts it on.
basically:

  • "ok thread aint running on scheduler"
    -"lets now take lock"
  • another thing is holding lock and maybe that other thing re-schedules the thread into the currently active thread
  • "uh oh fuck"
    Signed-off-by: lizzie lizzie@eden-emu.dev
Fixes potential race where thread may be told to be non-running but inbetween the acquisition of the lock there may be another holder whom puts it on. basically: - "ok thread aint running on scheduler" -"lets now take lock" - another thing is holding lock and maybe that other thing re-schedules the thread into the currently active thread - "uh oh fuck" Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from [core/hle/kernel] fix potential datarace where thread may be told to be non-running but inbetween the acquisition of the lock there may be another holder whom puts it on to [core/hle/kernel] fix potential datarace when re-scheduling threads at termination 2025-10-30 20:56:00 +01:00
Lizzie force-pushed lock-term-1 from 991d6d280d
Some checks reported errors
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build cancelled
Details
to d34400226b
Some checks failed
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build failed
Details
2025-10-30 21:03:31 +01:00 Compare
Lizzie changed title from [core/hle/kernel] fix potential datarace when re-scheduling threads at termination to WIP: [core/hle/kernel] fix potential datarace when re-scheduling threads at termination 2025-10-30 21:19:39 +01:00
DraVee commented 2025-12-27 18:54:49 +01:00
Member
Copy link

Need rebase and fix CI building

Need rebase and fix CI building
DraVee changed target branch from master to chore/NamespaceIndentation 2026-01-11 00:42:56 +01:00
DraVee force-pushed lock-term-1 from d34400226b
Some checks failed
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build failed
Details
to f7eb7b3610
Some checks failed
GitHub Actions [CI] Build failed
Details
2026-01-11 00:43:12 +01:00 Compare
DraVee commented 2026-01-11 00:44:25 +01:00
Member
Copy link

TODO: Add #3294 hash to .git-blame-ignore-revs when merged

TODO: Add #3294 hash to .git-blame-ignore-revs when merged
Lizzie commented 2026-01-30 20:22:20 +01:00
Author
Member
Copy link

Think not needed anymore :)

Think not needed anymore :)
DraVee commented 2026-01-30 20:37:58 +01:00
Member
Copy link

Closing it then (need to rebase anyway)

Closing it then (need to rebase anyway)
DraVee closed this pull request 2026-01-30 20:37:58 +01:00
Some checks failed
GitHub Actions [CI] Build failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#3294 [chore] k_thread.cpp: clang-format: NamespaceIndentation = NONE
eden-emu/eden
Reference
eden-emu/eden!2899
No description provided.