eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 57 Projects 1 Releases Wiki Activity Actions 1

[android] Various UX fixups / Improvements #2870

Open
kleidis wants to merge 8 commits from kleidis/eden:ux-improvements into master
pull from: kleidis/eden:ux-improvements
merge into: eden-emu:master
Conversation 3 Commits 8 Files changed 9 +188 -87
kleidis commented 2025-10-28 19:14:32 +01:00
Member
Copy link
  • Swap import / export icons on InstallablesFragment and GamePropertiesFragment
  • Redesign AddonFragment
  • Fix up colors for multiplayer bottom sheets
  • Fix up padding in multiplayer lobby browser
- Swap import / export icons on InstallablesFragment and GamePropertiesFragment - Redesign AddonFragment - Fix up colors for multiplayer bottom sheets - Fix up padding in multiplayer lobby browser
swap import / export icon on gamePropertiesFragment
Some checks reported errors
eden-license / license-header (pull_request) Failing after 35s
Details
GitHub Actions [CI] Build cancelled
Details
328882fe80
license header
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
016233c2f1
MaranBr approved these changes 2025-10-29 19:09:13 +01:00
Dismissed
Lizzie approved these changes 2025-10-29 19:45:15 +01:00
Dismissed
crueter requested changes 2025-10-30 03:25:04 +01:00
src/android/app/src/main/res/layout/card_installable_icon.xml Outdated
@ -67,3 +67,3 @@
android:tooltipText="@string/string_import"
android:visibility="gone"
app:icon="@drawable/ic_import"
app:icon="@drawable/ic_export"
crueter commented 2025-10-30 03:25:02 +01:00
Owner
Copy link

This is now in the wrong order. Exporting should be given an upload icon, while importing should be given a download icon.

This is now in the wrong order. Exporting should be given an upload icon, while importing should be given a download icon.
kleidis commented 2025-10-30 03:29:22 +01:00
Author
Member
Copy link

ic_import is the downward pointing arrow while ic_export the upward one, I took the suggestion of swapping these for better readability. Should i revert this?

ic_import is the downward pointing arrow while ic_export the upward one, I took the suggestion of swapping these for better readability. Should i revert this?
crueter commented 2025-10-30 03:30:15 +01:00
Owner
Copy link

Yes, the arrow pointing down indicates data is being put into the application (aka importing) and vice versa.

Yes, the arrow pointing down indicates data is being put into the application (aka importing) and vice versa.
Shinmegumi commented 2025-10-30 16:58:24 +01:00
Owner
Copy link

I disagree with this only because I think the icons should just be removed and it should just say import and export. If basic users don't understand what those two words mean, they shouldn't be even trying to use Eden.

I disagree with this only because I think the icons should just be removed and it should just say import and export. If basic users don't understand what those two words mean, they shouldn't be even trying to use Eden.
kleidis force-pushed ux-improvements from 016233c2f1
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 90dd9d3188
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-30 15:40:08 +01:00 Compare
kleidis dismissed MaranBr's review 2025-10-30 15:40:08 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

kleidis dismissed Lizzie's review 2025-10-30 15:40:08 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u ux-improvements:kleidis-ux-improvements
git switch kleidis-ux-improvements
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2870
No description provided.