[VK] spec-clean MasterSemaphore submits #285
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "mastersemaphore_specsafe"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fixes this error [ 18.505526] Render.Vulkan video_core/vulkan_common/vulkan_debug_callback.cpp:DebugUtilCallback:59: Validation Information: [ UNASSIGNED-BestPractices-SemaphoreCount ] | MessageID = 0x6cfe18a5 | pSubmits[0].pWaitSemaphores is set, but pSubmits[0].waitSemaphoreCount is 0.
This patch is only corrective in nature and is trivial and should not fix or break anything just one of the best practices in vulkan. It nulls pWaitSemaphores / pWaitDstStageMask / pSignalSemaphores when the corresponding counts are zero.
This just fixes it so it doesn't spam logs and such in debugging mode right? Does this show up in the logs outside of GPU Debugging?
@Shinmegumi wrote in #285 (comment):
no this error does not show up in current master because of the validation layer does not have best practices enabled
f3d4c46622
to116016137d