eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

[video_core] Add additional check to prevent graphics corruption when triggering fast buffer incorrectly #2824

Closed
MaranBr wants to merge 2 commits from fast_buffer into master
pull from: fast_buffer
merge into: eden-emu:master
Conversation 1 Commits 2 Files changed 1 +2 -1
MaranBr commented 2025-10-23 21:05:36 +02:00
Member
Copy link

This adds an additional check to prevent graphics corruption by triggering fast buffering incorrectly. Fixes a random bug with Yoshi's shadows in Yoshi's Crafted World and possibly others as well.

Fix: Translate TLDS: Unaligned source register R157 is not implemented

This adds an additional check to prevent graphics corruption by triggering fast buffering incorrectly. Fixes a random bug with Yoshi's shadows in Yoshi's Crafted World and possibly others as well. Fix: `Translate TLDS: Unaligned source register R157 is not implemented`
Add additional check to prevent graphics corruption when triggering fast buffer incorrectly
Some checks reported errors
eden-license / license-header (pull_request) Successful in 34s
Details
GitHub Actions [CI] Build cancelled
Details
baaea2fac2
DraVee requested changes 2025-10-23 21:20:09 +02:00
src/video_core/buffer_cache/buffer_cache.h Outdated
@ -790,12 +790,13 @@ void BufferCache<P>::BindHostGraphicsUniformBuffer(size_t stage, u32 index, u32
++channel_state->uniform_cache_shots[0];
const Binding& binding = channel_state->uniform_buffers[stage][index];
const DAddr device_addr = binding.device_addr;
const u32 size = (std::min)(binding.size, (*channel_state->uniform_buffer_sizes)[stage][index]);
DraVee commented 2025-10-23 21:20:03 +02:00
Member
Copy link

Needs (std::min) otherwise windows clang-cl throws a tantrum

Needs `(std::min)` otherwise windows clang-cl throws a tantrum
MaranBr commented 2025-10-23 21:40:40 +02:00
Author
Member
Copy link

Fixed

Fixed
MaranBr marked this conversation as resolved
Fix Clang build
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
48e5c9d5ab
MaranBr force-pushed fast_buffer from 48e5c9d5ab
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 57cb902c5c
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-24 13:22:51 +02:00 Compare
MaranBr force-pushed fast_buffer from 57cb902c5c
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 90bb5b9c9a
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-25 17:03:55 +02:00 Compare
MaranBr closed this pull request 2025-10-25 22:26:31 +02:00
MaranBr deleted branch fast_buffer 2025-10-25 22:26:36 +02:00
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
Lizzie
DraVee
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2824
No description provided.