eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 63 Projects 1 Releases Wiki Activity Actions

[cmake] sse2neon: vendor it! #2817

Merged
Maufeat merged 6 commits from DraVee/eden:cmake/sse2neon into master 2025-10-26 02:59:52 +01:00
Conversation 7 Commits 6 Files changed 5 +143 -9286
DraVee commented 2025-10-22 23:55:46 +02:00
Member
Copy link

sse2neon: Revert to "DLTcollab/sse2neon@66267b52fd74951d8c224a4ed8baad4102c3cfd7"

2024-01-30 21:15:29 +0800 Optimize CRC intrinisics for targets lacking of CRC extension
github.com/DLTcollab/sse2neon/commit/66267b52fd74951d8c224a4ed8baad4102c3cfd7

Signed-off-by: Caio Oliveira caiooliveirafarias0@gmail.com

sse2neon: Revert to "DLTcollab/sse2neon@66267b52fd74951d8c224a4ed8baad4102c3cfd7" 2024-01-30 21:15:29 +0800 Optimize CRC intrinisics for targets lacking of CRC extension github.com/DLTcollab/sse2neon/commit/66267b52fd74951d8c224a4ed8baad4102c3cfd7 * superseed #107 Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
[cmake] sse2neon: Vendor it and update to v1.8.0
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
9d9b69c6fc
 
* superseed #107

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
Lizzie commented 2025-10-23 00:10:43 +02:00
Member
Copy link

It breaks Android
Just vendor it for now

It breaks Android Just vendor it for now
DraVee force-pushed cmake/sse2neon from 9d9b69c6fc
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to 69b7b7e752
Some checks reported errors
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build cancelled
Details
2025-10-23 00:55:50 +02:00 Compare
DraVee force-pushed cmake/sse2neon from 69b7b7e752
Some checks reported errors
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build cancelled
Details
to 1bdf984129
Some checks failed
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build failed
Details
2025-10-23 00:56:54 +02:00 Compare
DraVee changed title from [cmake] sse2neon: Vendor it and update to v1.8.0 to [cmake] sse2neon: vendor it! 2025-10-23 00:59:36 +02:00
DraVee commented 2025-10-23 01:03:08 +02:00
Author
Member
Copy link

The commit that make the patch useless is:
DLTcollab/sse2neon@29716df957

But too many changes:
DLTcollab/sse2neon@66267b52fd...29716df957

The commit that make the patch useless is: https://github.com/DLTcollab/sse2neon/commit/29716df957401e9c357348e9b73c95a38cdcd34f But too many changes: https://github.com/DLTcollab/sse2neon/compare/66267b52fd74...29716df95740
oops
Some checks reported errors
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build cancelled
Details
43f5c2e391
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
DraVee force-pushed cmake/sse2neon from 43f5c2e391
Some checks reported errors
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build cancelled
Details
to 3e726795e9
Some checks failed
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build failed
Details
2025-10-23 01:13:29 +02:00 Compare
DraVee force-pushed cmake/sse2neon from 3e726795e9
Some checks failed
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build failed
Details
to e5d88c95d6
Some checks failed
eden-license / license-header (pull_request) Successful in 28s
Details
GitHub Actions [CI] Build failed
Details
2025-10-23 01:21:06 +02:00 Compare
.patch: Damn I'm dumb
Some checks reported errors
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build cancelled
Details
03f302c44a
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
.patch: I should read "How patch 101" or something like it
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
9d5d23c1a8
 
Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
Lizzie approved these changes 2025-10-23 04:39:37 +02:00
Dismissed
Lizzie scheduled this pull request to auto merge when all checks succeed 2025-10-23 04:40:49 +02:00
crueter requested changes 2025-10-23 04:41:41 +02:00
crueter left a comment
Owner
Copy link

Also, I'll need to add a custom source dir option for CPMUtil, because otherwise packagers will just be screwed if they can't download during configure--see nx_tzdb for an example (but more generally applicable)

Also, I'll need to add a custom source dir option for CPMUtil, because otherwise packagers will just be screwed if they can't download during configure--see nx_tzdb for an example (but more generally applicable)
CMakeLists.txt Outdated
@ -590,6 +590,7 @@ find_package(VulkanUtilityLibraries)
find_package(SimpleIni)
find_package(SPIRV-Tools)
find_package(sirit)
find_package(sse2neon)
crueter commented 2025-10-23 04:40:43 +02:00
Owner
Copy link

if (ARCHITECTURE_arm64)

`if (ARCHITECTURE_arm64)`
👍 1
DraVee marked this conversation as resolved
externals/CMakeLists.txt Outdated
@ -401,7 +401,8 @@ if (ANDROID)
endif()
# sse2neon
AddJsonPackage(sse2neon)
crueter commented 2025-10-23 04:40:52 +02:00
Owner
Copy link

Put this in the if block

Put this in the if block
DraVee marked this conversation as resolved
externals/cpmfile.json Outdated
@ -213,0 +215,4 @@
"repo": "DLTcollab/sse2neon",
"sha": "66267b52fd",
"hash": "3aed8676e1b8c428acb076464663e3968a721457b08710a7c5f8df2fbdaa5601053c1606169a55e987e7a58dd17e3cc3b7fbf953aa891c5ac5f8ce2941862e4b",
"find_args": "MODULE",
crueter commented 2025-10-23 04:40:25 +02:00
Owner
Copy link

Findsse2neon.cmake does not exist and probably won't since it's not really defined as a system module, so this can be replaced with download_only: true

`Findsse2neon.cmake` does not exist and probably won't since it's not really defined as a system module, so this can be replaced with `download_only: true`
DraVee marked this conversation as resolved
MaranBr approved these changes 2025-10-23 04:43:12 +02:00
Dismissed
crueter canceled auto merging this pull request when all checks succeed 2025-10-23 04:43:40 +02:00
(1/2)
Some checks reported errors
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build cancelled
Details
2aeda53245
DraVee dismissed Lizzie's review 2025-10-23 04:56:09 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

DraVee dismissed MaranBr's review 2025-10-23 04:56:09 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

(2/3)
Some checks reported errors
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build cancelled
Details
e4a02d317c
(3/3)
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
bd5a8c962b
Maufeat approved these changes 2025-10-23 08:31:20 +02:00
MaranBr approved these changes 2025-10-23 21:59:18 +02:00
Maufeat merged commit 470214412b into master 2025-10-26 02:59:52 +01:00
Maufeat referenced this pull request from a commit 2025-10-26 02:59:53 +01:00
[cmake] sse2neon: vendor it! (#2817)
Lizzie referenced this pull request from a commit 2025-10-26 19:39:36 +01:00
[cmake] sse2neon: vendor it! (#2817)
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
MrPurple666
crueter
Lizzie
Maufeat
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2817
No description provided.