eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 56 Projects 1 Releases Wiki Activity Actions

[dynarmic] remove bloated LUT usage that makes giant functions for no good reason #2801

Merged
Shinmegumi merged 2 commits from dynarmic-lut-obliterate into master 2025-10-22 12:23:16 +02:00
Conversation 2 Commits 2 Files changed 5 +225 -220
Lizzie commented 2025-10-20 22:41:41 +02:00
Member
Copy link

Long story short, each of these LUT generates a function that is only ran once, spam the entire code with bunch of little "specialized templates" (remember, N * M * L) and basically bloat codesize for no good reason
Additionally it tries to outsmart the compiler which it's not always a good idea - herein I replace most (except 1) of those "helper" LUTs with something the compiler can actually work satisfiably

Happy reminder of the sheer amount of functions spammed:
mcl::list thing generates a number from 0 to 63 for (fsize 64), add the 0-31 for fsize 32, 0-15 for fsize 16 and you got around... 64+32+16 = 112 functions for a single parameter
Now include in the equation rounding_mode, which is about, what, 6? so 112*6 = 672

Yeah

Signed-off-by: lizzie lizzie@eden-emu.dev

Long story short, each of these LUT generates a function that is only ran once, spam the entire code with bunch of little "specialized templates" (remember, N * M * L) and basically bloat codesize for no good reason Additionally it tries to outsmart the compiler which it's not always a good idea - herein I replace most (except 1) of those "helper" LUTs with something the compiler can actually work satisfiably Happy reminder of the sheer amount of functions spammed: mcl::list thing generates a number from 0 to 63 for (fsize 64), add the 0-31 for fsize 32, 0-15 for fsize 16 and you got around... 64+32+16 = 112 functions for a single parameter Now include in the equation rounding_mode, which is about, what, 6? so 112*6 = 672 Yeah Signed-off-by: lizzie <lizzie@eden-emu.dev>
[dynarmic] remove bloated LUT usage that makes giant functions for no good reason
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build started
Details
5619ae4764
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix
Some checks are pending
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build started
Details
d5dc2da321
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed dynarmic-lut-obliterate from d5dc2da321
Some checks are pending
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build started
Details
to 8ce5e6213a
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
2025-10-21 20:32:19 +02:00 Compare
crueter approved these changes 2025-10-22 04:34:11 +02:00
Shinmegumi approved these changes 2025-10-22 12:16:17 +02:00
Shinmegumi deleted branch dynarmic-lut-obliterate 2025-10-22 12:23:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
MrPurple666
MaranBr
crueter
Shinmegumi
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2801
No description provided.