eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

WIP: [android] opinionated UI changes for startup and first-out of the box experience #2799

Draft
Lizzie wants to merge 8 commits from opinion-android into master
pull from: opinion-android
merge into: eden-emu:master
Conversation 5 Commits 8 Files changed 29 +31 -194
Lizzie commented 2025-10-20 08:58:38 +02:00
Member
Copy link

(Very opinionated QoL for UI of Android)

  • Remove pre-alpha message: Everyone understands it's pre alpha don't need to nag about it
  • "Welcome" and "All done" (that one is needed for finishSetup()) pages that accomplish no utility other than require a tap
  • Allow user to ignore warnings about missing keys
  • "Add games"? you're selecting a folder not "games" per se.
  • Don't ask for bluetooth perms that's scary
    Signed-off-by: lizzie lizzie@eden-emu.dev
(Very opinionated QoL for UI of Android) - Remove pre-alpha message: Everyone understands it's pre alpha don't need to nag about it - "Welcome" and ~~"All done"~~ (that one is needed for finishSetup()) pages that accomplish no utility other than require a tap - Allow user to ignore warnings about missing keys - "Add games"? you're selecting a folder not "games" per se. - Don't ask for bluetooth perms that's scary Signed-off-by: lizzie <lizzie@eden-emu.dev>
[android] opinionated UI changes for startup and first-out of the box experience
Some checks are pending
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build started
Details
2176855aee
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
ok maybe we need the last page for finishSetup()
Some checks are pending
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build started
Details
9e5441fb25
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie force-pushed opinion-android from 9e5441fb25
Some checks are pending
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build started
Details
to 3b8893a8f2
Some checks are pending
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 09:10:20 +02:00 Compare
restore strings
Some checks are pending
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build started
Details
7ebed69c9d
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fine no custom strings either
Some checks are pending
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build started
Details
ee658a3aee
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
no need for 5 separate "learn more"
Some checks failed
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Failing after 27s
Details
fc019f21e2
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
kleidis commented 2025-10-20 11:01:53 +02:00
Member
Copy link

Since you decided to do this, might as well remove requestBluetoothPermissionsLauncher which I'm pretty sure it's not even needed

Since you decided to do this, might as well remove `requestBluetoothPermissionsLauncher` which I'm pretty sure it's not even needed
who needs bluetooth perms anyways
Some checks failed
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Failing after 27s
Details
0e39d274a1
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix
Some checks are pending
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build started
Details
3b81a4b802
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Lizzie changed title from WIP: [android] opinionated UI changes for startup and first-out of the box experience to [android] opinionated UI changes for startup and first-out of the box experience 2025-10-20 12:44:20 +02:00
Ghost commented 2025-10-20 21:05:32 +02:00
Copy link

I like these changes a lot. They should be merged.

I like these changes a lot. They should be merged.
Lizzie force-pushed opinion-android from 3b81a4b802
Some checks are pending
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build started
Details
to 43168ed15e
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
2025-10-21 20:33:00 +02:00 Compare
CamilleLaVey approved these changes 2025-10-22 05:13:17 +02:00
Dismissed
Lizzie force-pushed opinion-android from 43168ed15e
All checks were successful
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
to dcf507cecd
Some checks reported errors
eden-license / license-header (pull_request) Failing after 28s
Details
GitHub Actions [CI] Build cancelled
Details
2025-10-22 05:20:06 +02:00 Compare
Lizzie dismissed CamilleLaVey's review 2025-10-22 05:20:06 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fix
Some checks failed
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build failed
Details
bc78612fa7
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
DraVee commented 2025-10-22 22:42:07 +02:00
Member
Copy link

Need sync again, just to make sure CI passes

Need sync again, just to make sure CI passes
Lizzie force-pushed opinion-android from bc78612fa7
Some checks failed
eden-license / license-header (pull_request) Successful in 32s
Details
GitHub Actions [CI] Build failed
Details
to a0dd6538ce
All checks were successful
eden-license / license-header (pull_request) Successful in 37s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-23 11:07:34 +02:00 Compare
Maufeat approved these changes 2025-10-26 02:58:56 +01:00
Dismissed
crueter changed title from [android] opinionated UI changes for startup and first-out of the box experience to WIP: [android] opinionated UI changes for startup and first-out of the box experience 2025-10-26 03:00:23 +01:00
Lizzie changed title from WIP: [android] opinionated UI changes for startup and first-out of the box experience to [android] opinionated UI changes for startup and first-out of the box experience 2025-10-26 03:12:38 +01:00
Lizzie changed title from [android] opinionated UI changes for startup and first-out of the box experience to WIP: [android] opinionated UI changes for startup and first-out of the box experience 2025-10-26 03:23:18 +01:00
fix shell :)
Some checks failed
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build failed
Details
2f97b8f2a1
Lizzie dismissed Maufeat's review 2025-10-26 04:04:50 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie force-pushed opinion-android from 2f97b8f2a1
Some checks failed
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build failed
Details
to da90ca6113
Some checks failed
build.yml / fix shell :) (push) Failing after 0s
Details
trigger_release.yml / fix shell :) (push) Failing after 0s
Details
build.yml / fix shell :) (pull_request) Failing after 0s
Details
trigger_release.yml / fix shell :) (pull_request) Failing after 0s
Details
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-26 19:47:48 +01:00 Compare
Lizzie changed title from WIP: [android] opinionated UI changes for startup and first-out of the box experience to [android] opinionated UI changes for startup and first-out of the box experience 2025-10-26 20:51:26 +01:00
Lizzie force-pushed opinion-android from da90ca6113
Some checks failed
build.yml / fix shell :) (push) Failing after 0s
Details
trigger_release.yml / fix shell :) (push) Failing after 0s
Details
build.yml / fix shell :) (pull_request) Failing after 0s
Details
trigger_release.yml / fix shell :) (pull_request) Failing after 0s
Details
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
to be25e9c4bb
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
2025-10-26 20:51:39 +01:00 Compare
Lizzie changed title from [android] opinionated UI changes for startup and first-out of the box experience to WIP: [android] opinionated UI changes for startup and first-out of the box experience 2025-10-26 20:51:43 +01:00
All checks were successful
eden-license / license-header (pull_request) Successful in 31s
Required
Details
GitHub Actions [CI] Build succeeded
Details
GitHub Releases [CD] Build succeeded – Release published
Details
This pull request has changes conflicting with the target branch.
  • tools/unused-strings.sh
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin opinion-android:opinion-android
git switch opinion-android
Sign in to join this conversation.
Reviewers
No reviewers
crueter
MrPurple666
MaranBr
CamilleLaVey
Maufeat
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2799
No description provided.