eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

WIP: [vk] Renderpass Enhancements for Tile GPUs #2798

Closed
Ghost wants to merge 9 commits from (deleted):experiment7 into master
pull from: (deleted):experiment7
merge into: eden-emu:master
Conversation 1 Commits 9 Files changed 9 +319 -82
Ghost commented 2025-10-20 08:12:51 +02:00
Copy link
No description provided.
[vk] Renderpass Enhancements for Tile GPUs
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
0ce9d280aa
Ghost force-pushed experiment7 from 0ce9d280aa
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
to 59b2c1c605
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 08:13:40 +02:00 Compare
Ghost force-pushed experiment7 from 59b2c1c605
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
to 8d98102e48
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 08:17:57 +02:00 Compare
Ghost force-pushed experiment7 from 8d98102e48
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
to 32ddd19ae7
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 08:18:33 +02:00 Compare
Lizzie reviewed 2025-10-20 08:28:47 +02:00
src/video_core/renderer_vulkan/vk_scheduler.h Outdated
@ -233,0 +240,4 @@
return static_cast<u64>(reinterpret_cast<uintptr_t>(image));
}
[[nodiscard]] VkImageLayout GetTrackedLayout(VkImage image) const noexcept {
Lizzie commented 2025-10-20 08:28:47 +02:00
Member
Copy link

Don't think we need functions for this? Just directly access the map instead of using function wrappers
Will help readability first and foremost

Don't think we need functions for this? Just directly access the map instead of using function wrappers Will help readability first and foremost
Ghost commented 2025-10-20 08:42:13 +02:00
Copy link

You're right just changed it to map directly, thanks for catching that.

You're right just changed it to map directly, thanks for catching that.
Ghost marked this conversation as resolved
Ghost force-pushed experiment7 from 32ddd19ae7
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
to e20b4b3456
Some checks failed
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Failing after 28s
Details
2025-10-20 08:41:39 +02:00 Compare
Ghost force-pushed experiment7 from e20b4b3456
Some checks failed
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Failing after 28s
Details
to fc64740870
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 08:41:50 +02:00 Compare
Ghost force-pushed experiment7 from fc64740870
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
to 3512c20346
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 08:48:55 +02:00 Compare
VUID FIX
Some checks failed
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Failing after 27s
Details
5c05bf2d86
build fix
Some checks failed
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build started
Details
597371a514
Ghost force-pushed experiment7 from d98c5bf7c0
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
to 9667a8fe58
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build started
Details
2025-10-20 09:47:21 +02:00 Compare
Ghost force-pushed experiment7 from 9667a8fe58
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build started
Details
to db2fa37ad9
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
2025-10-21 02:10:04 +02:00 Compare
Ghost force-pushed experiment7 from db2fa37ad9
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
to fa68d3bcc3
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build started
Details
2025-10-21 02:10:13 +02:00 Compare
Ghost force-pushed experiment7 from fa68d3bcc3
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build started
Details
to 32b488a053
Some checks reported errors
eden-license / license-header (pull_request) Failing after 28s
Details
GitHub Actions [CI] Build cancelled
Details
2025-10-21 05:45:40 +02:00 Compare
Ghost force-pushed experiment7 from 32b488a053
Some checks reported errors
eden-license / license-header (pull_request) Failing after 28s
Details
GitHub Actions [CI] Build cancelled
Details
to c2d33e5de4
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
build.yml / more changes (pull_request) Failing after 0s
Details
trigger_release.yml / more changes (pull_request) Failing after 0s
Details
2025-10-21 05:57:57 +02:00 Compare
Ghost closed this pull request 2025-10-29 21:43:19 +01:00
Some checks failed
eden-license / license-header (pull_request) Failing after 27s
Required
Details
GitHub Actions [CI] Build succeeded – Release published
Details
build.yml / more changes (pull_request) Failing after 0s
Details
trigger_release.yml / more changes (pull_request) Failing after 0s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2798
No description provided.