eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

[qt] fix aspect ratio enum mismatch for framebuffer #2792

Merged
crueter merged 2 commits from fbmismatch into master 2025-10-21 21:39:10 +02:00
Conversation 2 Commits 2 Files changed 4 +48 -87
Lizzie commented 2025-10-20 04:27:32 +02:00
Member
Copy link

the framebuffer:

enum class AspectRatio {
    Default,
    R4_3,
    R21_9,
    R16_10,
    StretchToWindow,
};

the actual enum

ENUM(AspectRatio, R16_9, R4_3, R21_9, R16_10, Stretch);

If someone were to add a new setting it would likely cause catastrophe.

1280/720 = 16/9

Signed-off-by: lizzie lizzie@eden-emu.dev

the framebuffer: ```c++ enum class AspectRatio { Default, R4_3, R21_9, R16_10, StretchToWindow, }; ``` the actual enum ```c++ ENUM(AspectRatio, R16_9, R4_3, R21_9, R16_10, Stretch); ``` If someone were to add a new setting it would likely cause catastrophe. 1280/720 = 16/9 Signed-off-by: lizzie <lizzie@eden-emu.dev>
[qt] fix aspect ratio enum mismatch for framebuffer
Some checks reported errors
eden-license / license-header (pull_request) Failing after 26s
Details
GitHub Actions [CI] Build cancelled
Details
5bc910e75f
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
fix license
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded
Details
2cffe6e83b
 
Signed-off-by: lizzie <lizzie@eden-emu.dev>
MaranBr approved these changes 2025-10-21 21:36:53 +02:00
crueter approved these changes 2025-10-21 21:39:04 +02:00
crueter merged commit d0206c35fb into master 2025-10-21 21:39:10 +02:00
crueter deleted branch fbmismatch 2025-10-21 21:39:10 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
CamilleLaVey
Maufeat
MaranBr
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2792
No description provided.