[android, tools] remove unused XML strings; add script to find unused XML strings #2777

Merged

MaranBr merged 5 commits from unused-android-strings into master 2025-10-19 04:57:48 +02:00

Conversation 5 Commits 5 Files changed 27 +89 -1800

Lizzie commented 2025-10-19 01:57:03 +02:00

Member

Copy link

Signed-off-by: lizzie lizzie@eden-emu.dev

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 01:57:03 +02:00

[android, tools] remove unused XML strings; add script to find unused XML strings ... 5e60622019

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie requested reviews from CamilleLaVey, Maufeat, crueter, MrPurple666, MaranBr 2025-10-19 01:57:03 +02:00

crueter commented 2025-10-19 01:58:16 +02:00

Owner

Copy link

posix shell would be a lot easier imo

posix shell would be a lot easier imo

Lizzie commented 2025-10-19 02:01:19 +02:00

Author

Member

Copy link

@crueter wrote in #2777 (comment):

posix shell would be a lot easier imo

I highly prefer perl for these kind of stuff - especially since it's already an implicit (build) dependency - also because this kind of array fiddling gets weird on POSIX shell

@crueter wrote in https://git.eden-emu.dev/eden-emu/eden/pulls/2777#issuecomment-7309: > posix shell would be a lot easier imo I highly prefer perl for these kind of stuff - especially since it's already an implicit (build) dependency - also because this kind of array fiddling gets weird on POSIX shell

crueter commented 2025-10-19 02:07:53 +02:00

Owner

Copy link

Perl is completely broken by default on Windows and also not necessarily required.

For arrays, usually you can work around it or use set -- and "$@" (or just use bash)

Perl is completely broken by default on Windows and also not necessarily required. For arrays, usually you can work around it or use `set -- ` and `"$@"` (or just use bash)

crueter added 1 commit 2025-10-19 03:56:28 +02:00

faster unused string find ... 30bb31c9eb

Signed-off-by: crueter <crueter@eden-emu.dev>

crueter added 1 commit 2025-10-19 04:05:05 +02:00

also remove from translations ... 38bdb61ac0

Signed-off-by: crueter <crueter@eden-emu.dev>

crueter added 1 commit 2025-10-19 04:05:52 +02:00

license header ... e4c3edd7de

Signed-off-by: crueter <crueter@eden-emu.dev>

crueter added 1 commit 2025-10-19 04:31:08 +02:00

stale translations script ... e8aa3f8747

Signed-off-by: crueter <crueter@eden-emu.dev>

crueter approved these changes 2025-10-19 04:57:07 +02:00

MaranBr approved these changes 2025-10-19 04:57:38 +02:00

MaranBr merged commit df653d6ca4 into master 2025-10-19 04:57:48 +02:00

MaranBr deleted branch unused-android-strings 2025-10-19 04:57:48 +02:00

MaranBr referenced this pull request from a commit 2025-10-19 04:57:49 +02:00

[android, tools] remove unused XML strings; add script to find unused XML strings (#2777)

Sign in to join this conversation.

Reviewers

No reviewers

CamilleLaVey

Maufeat

MrPurple666

crueter

MaranBr

Labels

Clear labels   

android

Specific to android platform

  

audio

  

bug

Something is not working

  

ci

For changes to the ci/building

  

cmake

  

confirmed

Used when testers confirm a bug is reported and it is reproducable.

  

core

For core changes to the emulator

  

desktop

Specific to desktop PCs, handhelds, etc.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Frontend changes

  

fw

Changes related to firmware

  

git

For enhancements or changes regarding git.

  

graphics

  

loader

For changes to any of the loader implementations

  

nv gpu

For use with changes that involve the emulator GPU and any services.

  

ui

  

vulkan

Used on anything Vulkan-related

No labels

android

audio

bug

ci

cmake

confirmed

core

desktop

duplicate

enhancement

frontend

fw

git

graphics

loader

nv gpu

ui

vulkan

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

eden-emu/eden!2777

No description provided.