[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency #2775

Merged

MaranBr merged 15 commits from dynarmic-rem-templ into master 2025-10-28 03:46:25 +01:00

Conversation 2 Commits 15 Files changed 43 +351 -410

Lizzie commented 2025-10-18 22:42:30 +02:00

Member

Copy link

• std::bit_cast already on libc++ (see also #2774)
• type trait is a 5-liner for u8/u16/u32/u64
• UNREACHABLE(); can just be converted into __builtin_unreachable() (TODO: eventually phase out to std::unreachable() once all platforms support it)
  The templatery parametrization is creating many copies of the same function, polluting i-cache and just bloating code size for minimal savings (and in fact could be negative net savings because of the bloated code size) - this is mostly in preparation to a partial removal of template<size_t XXX> in functions to remove instancing (think of the function being copied x4 times... because the compiler is forced to inline it...)
  Signed-off-by: lizzie lizzie@eden-emu.dev

- std::bit_cast already on libc++ (see also #2774) - type trait is a 5-liner for u8/u16/u32/u64 - UNREACHABLE(); can just be converted into __builtin_unreachable() (TODO: eventually phase out to std::unreachable() once all platforms support it)\ The templatery parametrization is creating many copies of the same function, polluting i-cache and just bloating code size for minimal savings (and in fact could be negative net savings because of the bloated code size) - this is mostly in preparation to a partial removal of template<size_t XXX> in functions to remove instancing (think of the function being copied x4 times... because the compiler is forced to inline it...) Signed-off-by: lizzie lizzie@eden-emu.dev

Lizzie added 8 commits 2025-10-18 22:42:31 +02:00

remove always_false ... 0f0103c9fb

Signed-off-by: lizzie <lizzie@eden-emu.dev>

remove mcl integer_of_size ... 18f9c6be2b

Signed-off-by: lizzie <lizzie@eden-emu.dev>

remove always_false.h from camke ... 5aa004205c

Signed-off-by: lizzie <lizzie@eden-emu.dev>

replace with std::bit_cast, fix integer_of_size ... ee1c3dc1f8

Signed-off-by: lizzie <lizzie@eden-emu.dev>

no aliases, fix type util ... f03c6571cb

Signed-off-by: lizzie <lizzie@eden-emu.dev>

smaller macros ... 2f748b4237

Signed-off-by: lizzie <lizzie@eden-emu.dev>

remove mcl/architecture dependency ... c6264fe3f7

Signed-off-by: lizzie <lizzie@eden-emu.dev>

license fix ... 6c86d4e3ee

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie requested reviews from crueter, CamilleLaVey, Maufeat, MrPurple666, MaranBr 2025-10-18 22:42:31 +02:00

Lizzie added 1 commit 2025-10-19 05:27:11 +02:00

fix ... 646f0862d2

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 06:14:27 +02:00

fix x86_64 ... 2c5814db09

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 06:18:24 +02:00

fix headers pt 2 ... 21322994d9

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 07:06:31 +02:00

fix path choices ... 632b0be2a9

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 10:09:34 +02:00

fixup ... 7cb703dbd3

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie added 1 commit 2025-10-19 10:11:52 +02:00

fixes ... 4cbe0264c2

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Lizzie force-pushed dynarmic-rem-templ from 4cbe0264c2 to 3acde4f3cf 2025-10-23 11:14:48 +02:00 Compare

crueter added this to the 0.0.4 (real) milestone 2025-10-27 08:00:43 +01:00

crueter removed this from the 0.0.4 (real) milestone 2025-10-27 19:00:58 +01:00

Lizzie force-pushed dynarmic-rem-templ from 3acde4f3cf to 8c5a505309 2025-10-28 02:38:19 +01:00 Compare

crueter approved these changes 2025-10-28 02:49:57 +01:00

MaranBr approved these changes 2025-10-28 02:51:27 +01:00

MaranBr merged commit 61ab1be0e7 into master 2025-10-28 03:46:25 +01:00

MaranBr deleted branch dynarmic-rem-templ 2025-10-28 03:46:26 +01:00

MaranBr referenced this pull request from a commit 2025-10-28 03:46:26 +01:00

[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)

Lizzie referenced this pull request from a commit 2025-10-28 09:39:11 +01:00

Revert "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)"

Lizzie referenced this pull request 2025-10-28 09:39:18 +01:00

Revert "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)" #2861

Maufeat referenced this pull request from a commit 2025-10-28 13:50:26 +01:00

Revert "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)"

Maufeat referenced this pull request 2025-10-28 13:50:37 +01:00

Revert "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)" #2863

Shinmegumi referenced this pull request from a commit 2025-10-28 14:14:44 +01:00

Revert "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)" (#2863)

Lizzie referenced this pull request from a commit 2025-10-28 17:27:20 +01:00

Reapply "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)" (#2863)

Lizzie referenced this pull request 2025-10-28 17:27:48 +01:00

WIP: Reapply "[dynarmic] replace mcl::bit_cast with std::bit_cast; fix IR_emit codepath warnings for UNREACHABLE(); remove type trait mcl::integer_of_size dependency (#2775)" (#2863) #2865

Sign in to join this conversation.

Reviewers

No reviewers

CamilleLaVey

Maufeat

MrPurple666

crueter

MaranBr

Labels

Clear labels   

android

Specific to android platform

  

audio

  

bug

Something is not working

  

ci

For changes to the ci/building

  

cmake

  

confirmed

Used when testers confirm a bug is reported and it is reproducable.

  

core

For core changes to the emulator

  

desktop

Specific to desktop PCs, handhelds, etc.

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Frontend changes

  

fw

Changes related to firmware

  

git

For enhancements or changes regarding git.

  

graphics

  

loader

For changes to any of the loader implementations

  

nv gpu

For use with changes that involve the emulator GPU and any services.

  

ui

  

vulkan

Used on anything Vulkan-related

No labels

android

audio

bug

ci

cmake

confirmed

core

desktop

duplicate

enhancement

frontend

fw

git

graphics

loader

nv gpu

ui

vulkan

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

eden-emu/eden!2775

No description provided.