eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

[qt] fix translations #2773

Merged
MaranBr merged 4 commits from fix-translations into master 2025-10-18 22:19:07 +02:00
Conversation 2 Commits 4 Files changed 11 +234 -193
crueter commented 2025-10-18 19:56:09 +02:00
Owner
Copy link

Linguist strongly dislikes lookup tables of this sort due to the fact
that it looks for tr(), qsTr(), etc. when determining what strings need
translations. However, it does provide QT_TR_NOOP which marks the
string for translation without running the translation, which is designed
to allow for static or constexpr lookup tables. So let's use that.

Signed-off-by: crueter crueter@eden-emu.dev

Linguist strongly dislikes lookup tables of this sort due to the fact that it looks for tr(), qsTr(), etc. when determining what strings need translations. However, it does provide QT_TR_NOOP which marks the string for translation *without* running the translation, which is designed to allow for static or constexpr lookup tables. So let's use that. Signed-off-by: crueter <crueter@eden-emu.dev>
[qt] fix translations
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
107372df59
 
Linguist strongly dislikes lookup tables of this sort due to the fact
that it looks for tr(), qsTr(), etc. when determining what strings need
translations. To fix this, we can create a "fake" tr function that gets
Linguist to recognize the strings while keeping them constexpr; then,
the Lookup function can translate them at runtime.

Signed-off-by: crueter <crueter@eden-emu.dev>
use QT_TR_NOOP
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
fa07687fd3
 
Signed-off-by: crueter <crueter@eden-emu.dev>
crueter force-pushed fix-translations from fa07687fd3
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
to af1943cabc
Some checks failed
eden-license / license-header (pull_request) Successful in 30s
Details
GitHub Actions [CI] Build failed
Details
2025-10-18 20:02:46 +02:00 Compare
fixup migrator
Some checks reported errors
eden-license / license-header (pull_request) Successful in 29s
Details
GitHub Actions [CI] Build cancelled
Details
94b0a1289a
 
Signed-off-by: crueter <crueter@eden-emu.dev>
fix
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded
Details
40abde010b
 
Signed-off-by: crueter <crueter@eden-emu.dev>
MaranBr approved these changes 2025-10-18 20:46:38 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-18 20:46:55 +02:00
Lizzie approved these changes 2025-10-18 22:19:04 +02:00
MaranBr merged commit a53823646c into master 2025-10-18 22:19:07 +02:00
MaranBr deleted branch fix-translations 2025-10-18 22:19:07 +02:00
MaranBr referenced this pull request from a commit 2025-10-18 22:19:08 +02:00
[qt] fix translations (#2773)
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
CamilleLaVey
Maufeat
MaranBr
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2773
No description provided.