added barriers against zero valued overlayControlData.individualScale #2721

Merged

Shinmegumi merged 1 commit from xbzk-default-overlay-scale-fix into master

2025-10-13 15:37:43 +02:00

xbzk commented

2025-10-12 03:10:24 +02:00

Member

Some recent change already in master caused some @android users to reach a state in which they were missing individualScale value to some input overlay controls.

I was affected, and some fella in #tester-chat even shared a video.

These 3 new barriers makes eden ignore individualScales if they're zeroed (feeding 1f instead), avoiding the crash, and allowing users to further adjust controls scales.

Safe and functional.

Some recent change already in master caused some @android users to reach a state in which they were missing individualScale value to some input overlay controls. I was affected, and some fella in #tester-chat even shared a video. These 3 new barriers makes eden ignore individualScales if they're zeroed (feeding 1f instead), avoiding the crash, and allowing users to further adjust controls scales. Safe and functional.

xbzk added 1 commit

2025-10-12 03:10:25 +02:00

added barriers against zero valued individualScale

eden-license / license-header (pull_request) Successful in 29s

Details

b16caf13e3

xbzk requested reviews from MaranBr, Lizzie, CamilleLaVey, Maufeat, crueter, MrPurple666

2025-10-12 03:10:25 +02:00

xbzk commented

2025-10-12 03:13:45 +02:00

Author

Member

i've tested by forcing individualScales=0 editting config.ini externally, and confirmed it makes launching any game to crash.
then tried again with this fix and got all sweet again.

i've tested by forcing individualScales=0 editting config.ini externally, and confirmed it makes launching any game to crash. then tried again with this fix and got all sweet again.