eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 58 Projects 1 Releases Wiki Activity Actions

[vk] Introduce Ring Buffers for Uniform Buffer #2698

Merged
MaranBr merged 3 commits from buffercache into master 2025-10-10 19:24:21 +02:00
Conversation 2 Commits 3 Files changed 2 +72 -2
Shinmegumi commented 2025-10-08 19:12:11 +02:00
Owner
Copy link

Create 3 ring buffers which rotates between buffers each frame to avoid GPU/CPU conflicts
BindMappedUniformBuffer first tries to allocate from the ring buffer and falls back to staging pool only if allocation is too large.
Note to testers:- please test the performance since it is primarily a performance optimization and also look for visual bugs.

Create 3 ring buffers which rotates between buffers each frame to avoid GPU/CPU conflicts BindMappedUniformBuffer first tries to allocate from the ring buffer and falls back to staging pool only if allocation is too large. Note to testers:- please test the performance since it is primarily a performance optimization and also look for visual bugs.
MaranBr force-pushed buffercache from 4f9f90d9b4
Some checks failed
eden-license / license-header (pull_request) Failing after 28s
Details
to 8f11ce89e3
Some checks failed
eden-license / license-header (pull_request) Failing after 29s
Details
2025-10-10 02:09:09 +02:00 Compare
Shinmegumi changed title from WIP: [vk] Introduce Ring Buffers for Uniform Buffer to [vk] Introduce Ring Buffers for Uniform Buffer 2025-10-10 02:22:35 +02:00
MaranBr force-pushed buffercache from 8f11ce89e3
Some checks failed
eden-license / license-header (pull_request) Failing after 29s
Details
to 217e55a479
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
2025-10-10 14:49:49 +02:00 Compare
Fix headers
All checks were successful
eden-license / license-header (pull_request) Successful in 28s
Details
490479a028
MaranBr approved these changes 2025-10-10 17:25:51 +02:00
MaranBr scheduled this pull request to auto merge when all checks succeed 2025-10-10 17:25:59 +02:00
Lizzie approved these changes 2025-10-10 19:24:18 +02:00
MaranBr merged commit 776958c79d into master 2025-10-10 19:24:20 +02:00
MaranBr deleted branch buffercache 2025-10-10 19:24:21 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
CamilleLaVey
Maufeat
crueter
MrPurple666
MaranBr
Lizzie
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2698
No description provided.