eden-emu/eden
24
3
Fork 16
Code Issues 139 Pull requests 57 Projects 1 Releases Wiki Activity Actions

[frontend, android] Move update_checker to frontend_common and add Android support #2687

Merged
crueter merged 13 commits from kleidis/eden:update-checker-android into master 2025-10-21 23:36:36 +02:00
Conversation 7 Commits 13 Files changed 50 +221 -110
kleidis commented 2025-10-06 17:25:34 +02:00
Member
Copy link

I still have to add a setting to disable the auto update checking on a later PR, firstly lets make sure i didn't accidentally break anything with CMAKE. or QT.

I still have to add a setting to disable the auto update checking on a later PR, firstly lets make sure i didn't accidentally break anything with CMAKE. or QT.
DraVee requested changes 2025-10-06 19:04:34 +02:00
CMakeLists.txt Outdated
@ -570,0 +575,4 @@
message(STATUS "DEVEL=$ENV{DEVEL}: Disabling updates checker for development builds")
set(ENABLE_UPDATE_CHECKER OFF)
endif()
endif()
DraVee commented 2025-10-06 19:04:30 +02:00
Member
Copy link

I don't think this a good way to check for DEVEL, as we shouldn't rely on system environment variables (or at least I think we shouldn't

I don't think this a good way to check for DEVEL, as we shouldn't rely on system environment variables (or at least I think we shouldn't
crueter commented 2025-10-07 02:27:58 +02:00
Owner
Copy link

Yeah, DEVEL should be CI-local, not CMake-based

Yeah, `DEVEL` should be CI-local, not CMake-based
kleidis marked this conversation as resolved
src/frontend_common/CMakeLists.txt Outdated
@ -1,5 +1,5 @@
# SPDX-FileCopyrightText: 2023 yuzu Emulator Project
# SPDX-License-Identifier: GPL-2.0-or-later
# SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
# SPDX-License-Identifier: GPL-3.0-or-later
DraVee commented 2025-10-06 19:02:32 +02:00
Member
Copy link

Dont remove old copyright header

Dont remove old copyright header
kleidis marked this conversation as resolved
CamilleLaVey approved these changes 2025-10-07 02:24:24 +02:00
Dismissed
Lizzie approved these changes 2025-10-07 04:12:13 +02:00
Dismissed
crueter changed title from [frontend, android] Move update_checker to frontend_common and add Android support to WIP: [frontend, android] Move update_checker to frontend_common and add Android support 2025-10-07 04:19:35 +02:00
crueter added this to the 0.0.4 (real) milestone 2025-10-10 02:45:41 +02:00
crueter force-pushed update-checker-android from a34d1aeaa4
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 0ea5d4a6ae
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
2025-10-15 22:18:25 +02:00 Compare
crueter dismissed CamilleLaVey's review 2025-10-15 22:18:25 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

crueter dismissed Lizzie's review 2025-10-15 22:18:25 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

kleidis force-pushed update-checker-android from 0ea5d4a6ae
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
to 1b32e69cea
All checks were successful
eden-license / license-header (pull_request) Successful in 29s
Details
2025-10-16 04:41:05 +02:00 Compare
fix rebase mistake
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
e249bc3394
crueter commented 2025-10-17 22:30:34 +02:00
Owner
Copy link

so to clarify we do not want DEVEL handled by CMake or Gradle, this is handled separately in the workflow repo

so to clarify we do not want DEVEL handled by CMake or Gradle, this is handled separately in the workflow repo
kleidis changed title from WIP: [frontend, android] Move update_checker to frontend_common and add Android support to [frontend, android] Move update_checker to frontend_common and add Android support 2025-10-17 22:32:37 +02:00
kleidis force-pushed update-checker-android from e249bc3394
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
to 6acb75e70e
All checks were successful
eden-license / license-header (pull_request) Successful in 30s
Details
2025-10-18 08:15:27 +02:00 Compare
remove update checker flag in build.gradle
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
fa13d8febe
crueter force-pushed update-checker-android from fa13d8febe
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to f7e92e4dbe
Some checks failed
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build failed
Details
2025-10-18 20:54:09 +02:00 Compare
MaranBr force-pushed update-checker-android from f7e92e4dbe
Some checks failed
eden-license / license-header (pull_request) Successful in 26s
Details
GitHub Actions [CI] Build failed
Details
to 312a6ed8ce
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
2025-10-19 04:40:08 +02:00 Compare
kleidis force-pushed update-checker-android from 312a6ed8ce
All checks were successful
eden-license / license-header (pull_request) Successful in 26s
Details
to 7623dfaa39
Some checks are pending
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Successful in 34s
Details
2025-10-20 08:02:35 +02:00 Compare
kleidis force-pushed update-checker-android from 7623dfaa39
Some checks are pending
GitHub Actions [CI] Build started
Details
eden-license / license-header (pull_request) Successful in 34s
Details
to e0c081ee33
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
2025-10-21 20:06:58 +02:00 Compare
Lizzie approved these changes 2025-10-21 20:30:29 +02:00
Dismissed
kleidis force-pushed update-checker-android from e0c081ee33
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
to 279e77c21e
All checks were successful
eden-license / license-header (pull_request) Successful in 27s
Details
GitHub Actions [CI] Build succeeded – Release published
Details
2025-10-21 22:35:19 +02:00 Compare
kleidis dismissed Lizzie's review 2025-10-21 22:35:20 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Lizzie approved these changes 2025-10-21 23:14:03 +02:00
crueter approved these changes 2025-10-21 23:36:32 +02:00
crueter merged commit cde02bfe46 into master 2025-10-21 23:36:36 +02:00
crueter deleted branch update-checker-android 2025-10-21 23:36:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Maufeat
MrPurple666
MaranBr
DraVee
CamilleLaVey
Lizzie
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
cmake

   
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui

   
vulkan

Used on anything Vulkan-related

No labels
android
audio
bug
ci
cmake
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
vulkan
Milestone
Clear milestone
No items
No milestone
0.0.4 (real)
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eden-emu/eden!2687
No description provided.