eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[externals] only build spirv-tools as static #2680

Merged
crueter merged 1 commit from fix/spirv-tools into master 2025-10-07 01:31:37 +02:00
Conversation 2 Commits 1 Files changed 2 +5 -5
crueter commented 2025-10-06 02:48:37 +02:00
Owner
Copy link

Upstream forcefully builds the shared lib and also builds shared and
static separately for... some reason. I made a PR that fixes that, so
for now let's use it here

should speed up build on Android and Windows

Signed-off-by: crueter crueter@eden-emu.dev

Upstream forcefully builds the shared lib and also builds shared and static separately for... some reason. I made a PR that fixes that, so for now let's use it here should speed up build on Android and Windows Signed-off-by: crueter <crueter@eden-emu.dev>
crueter added 1 commit 2025-10-06 02:48:38 +02:00
[externals] only build spirv-tools as static
All checks were successful
eden-license / license-header (pull_request) Successful in 23s
Details
01aa35a90f 
Upstream forcefully builds the shared lib and also builds shared and
static separately for... some reason. I made a PR that fixes that, so
for now let's use it here

should speed up build on Android and Windows

Signed-off-by: crueter <crueter@eden-emu.dev>
requested reviews from MrPurple666, MaranBr, Lizzie, CamilleLaVey, Maufeat 2025-10-06 02:48:38 +02:00
CamilleLaVey approved these changes 2025-10-06 18:21:57 +02:00
MaranBr approved these changes 2025-10-06 18:22:12 +02:00
crueter merged commit 6a4fa11ac3 into master 2025-10-07 01:31:37 +02:00
crueter deleted branch fix/spirv-tools 2025-10-07 01:31:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPurple666
Lizzie
Maufeat
CamilleLaVey
MaranBr
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2680
No description provided.
Delete branch "fix/spirv-tools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?