eden-emu/eden
24
3
Fork 15
Code Issues 138 Pull requests 56 Projects 1 Releases Packages Wiki Activity Actions

[vk] Implement Shader Read Barrier #2671

Merged
MaranBr merged 4 commits from Ribbit/ribbitvulkanadditions:shaderreadbarrier into master 2025-10-04 23:58:08 +02:00
Conversation 5 Commits 4 Files changed 4 +95 -20
Ribbit commented 2025-10-04 07:07:00 +02:00
Contributor
Copy link

Adding the shader read barrier keeps every render/compute/transfer write visible before the image is sampled, so it prevents the “read-before-writes-finish” hazards. Without it you can get random stale frames, flickering post process passes, partially updated HUD textures, and corrupted depth-to-color conversions especially in scenes that render into an offscreen image and immediately feed that image to a shader (reflections, bloom, dynamic resolution, depth visualizers, etc.). This fix makes those R2T chains deterministic again across all Vulkan drivers.

Adding the shader read barrier keeps every render/compute/transfer write visible before the image is sampled, so it prevents the “read-before-writes-finish” hazards. Without it you can get random stale frames, flickering post process passes, partially updated HUD textures, and corrupted depth-to-color conversions especially in scenes that render into an offscreen image and immediately feed that image to a shader (reflections, bloom, dynamic resolution, depth visualizers, etc.). This fix makes those R2T chains deterministic again across all Vulkan drivers.
Ribbit added 3 commits 2025-10-04 07:07:01 +02:00 
This fixes stutters and freezes when playing FMV content in some games.

Reviewed-on: #2650
Co-authored-by: MaranBr <maranbr@outlook.com>
Co-committed-by: MaranBr <maranbr@outlook.com>
revert [video_core] Fix stutters and freezes when playing FMV content in some games (#2650)

This fixes stutters and freezes when playing FMV content in some games.

Reviewed-on: #2650
Co-authored-by: MaranBr <maranbr@outlook.com>
Co-committed-by: MaranBr <maranbr@outlook.com>
[vk] Implement Shader Read Barrier
Some checks failed
eden-license / license-header (pull_request) Failing after 25s
Details
b41f131670
requested reviews from MaranBr, Lizzie, CamilleLaVey, Maufeat, crueter, MrPurple666 2025-10-04 07:07:01 +02:00
Ribbit force-pushed shaderreadbarrier from b41f131670 to 8b210fd7a4 2025-10-04 07:07:11 +02:00 Compare
requested reviews from wildcard and removed review requests for MrPurple666, Maufeat 2025-10-04 09:22:33 +02:00
Ribbit force-pushed shaderreadbarrier from 8b210fd7a4 to ab90bc74e0 2025-10-04 09:27:40 +02:00 Compare
crueter requested changes 2025-10-04 09:50:24 +02:00
Dismissed
src/video_core/engines/maxwell_dma.cpp Outdated
@ -64,6 +64,7 @@ void MaxwellDMA::Launch() {
// TODO(Subv): Perform more research and implement all features of this engine.
const LaunchDMA& launch = regs.launch_dma;
ASSERT(launch.interrupt_type == LaunchDMA::InterruptType::NONE);
ASSERT(launch.data_transfer_type == LaunchDMA::DataTransferType::NON_PIPELINED);
crueter commented 2025-10-04 09:50:07 +02:00
Owner
Copy link

rebase fail

rebase fail
👍 1
Ribbit marked this conversation as resolved
src/video_core/engines/maxwell_dma.cpp Outdated
@ -156,6 +157,8 @@ void MaxwellDMA::Launch() {
}
void MaxwellDMA::CopyBlockLinearToPitch() {
UNIMPLEMENTED_IF(regs.launch_dma.remap_enable != 0);
crueter commented 2025-10-04 09:50:13 +02:00
Owner
Copy link

rebase fail

rebase fail
👍 1
Ribbit marked this conversation as resolved
Ribbit force-pushed shaderreadbarrier from ab90bc74e0 to cc28b585e3 2025-10-04 09:59:32 +02:00 Compare
requested review from crueter 2025-10-04 10:03:53 +02:00
Ribbit commented 2025-10-04 10:13:05 +02:00
Author
Contributor
Copy link

Git commands are denying me access to edit this for some reason so idk how to resolve it so I just updated my branch instead

Git commands are denying me access to edit this for some reason so idk how to resolve it so I just updated my branch instead
Ribbit force-pushed shaderreadbarrier from cc28b585e3 to efda6ed9a6 2025-10-04 22:41:33 +02:00 Compare
Ribbit commented 2025-10-04 22:42:32 +02:00
Author
Contributor
Copy link

Fixed my mistake earlier so it wont conflict now

Fixed my mistake earlier so it wont conflict now
Ribbit added 1 commit 2025-10-04 22:44:54 +02:00
Add missing header
All checks were successful
eden-license / license-header (pull_request) Successful in 20s
Details
7ebabb1745
MaranBr approved these changes 2025-10-04 22:52:06 +02:00
crueter approved these changes 2025-10-04 23:55:59 +02:00
MaranBr merged commit 268918aece into master 2025-10-04 23:58:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Lizzie
CamilleLaVey
wildcard
MaranBr
crueter
Labels
Clear labels   
android

Specific to android platform

  
audio

   
bug

Something is not working

  
ci

For changes to the ci/building

  
confirmed

Used when testers confirm a bug is reported and it is reproducable.

  
core

For core changes to the emulator

  
desktop

Specific to desktop PCs, handhelds, etc.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Frontend changes

  
fw

Changes related to firmware

  
git

For enhancements or changes regarding git.

  
graphics

   
loader

For changes to any of the loader implementations

  
nv gpu

For use with changes that involve the emulator GPU and any services.

  
ui
No labels
android
audio
bug
ci
confirmed
core
desktop
duplicate
enhancement
frontend
fw
git
graphics
loader
nv gpu
ui
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: eden-emu/eden#2671
No description provided.
Delete branch "Ribbit/ribbitvulkanadditions:shaderreadbarrier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?